Skip to content

bpo-33274: Compliance with DOM L1: return removed attribute #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1,355 commits into from
Closed

bpo-33274: Compliance with DOM L1: return removed attribute #7464

wants to merge 1,355 commits into from

Conversation

arikrupnik
Copy link
Contributor

@arikrupnik arikrupnik commented Jun 7, 2018 •
edited by bedevere-bot
Loading

W3C DOM Level 1[1] requires removeAttributeNode() to return the removed node:

removeAttributeNode: Removes the specified attribute.
Return Value: The Attr node that was removed.

Current implementation returns None.

[1]https://www.w3.org/TR/1998/REC-DOM-Level-1-19981001/level-one-core.html#method-removeAttributeNode

https://bugs.python.org/issue33274

https://bugs.python.org/issue33274

miss-islington and others added 30 commits December 21, 2017 14:54
@miss-islington @asvetlov
bpo-32323: urllib.parse.urlsplit() must not lowercase() IPv6 scope va…
fdb148f 
…lue (GH-4867) (#4959)

(cherry picked from commit fbd6051)
@miss-islington @asvetlov
bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter …
3bc68cf 
…shutdown (GH-4956) (#4962)

(cherry picked from commit 4a02543)
@vstinner
bpo-20891: Skip test_embed.test_bpo20891() (#4967) (#4969)
2e1ef00 
Skip the test failing randomly because of known race condition.

Skip the test to fix macOS buildbots until a decision is made on the
proper fix for the race condition.

(cherry picked from commit 550ee05)
@miss-islington @benjaminp
bpo-24960: use pkgutil.get_data in lib2to3 to read pickled grammar fi…
c1b8eb8 
…les (GH-4977) (#4979)

This is more complicated than it should be because we need to preserve the
useful mtime-based regeneration feature that lib2to3.pgen2.driver.load_grammar
has. We only look for the pickled grammar file with pkgutil.get_data and only if
the source file does not exist.
(cherry picked from commit 8a58771)
@miss-islington @benjaminp
correct wording (GH-4983) (#4984)
6ba0637 
(cherry picked from commit d11e8e0)
@miss-islington @asvetlov
bpo-26133: Clear signals list on interpreter finalizing (GH-5002) (#5003
5ff5d11 
)

(cherry picked from commit 4f146f9)
@miss-islington @serhiy-storchaka
bpo-29084: Exclude C API for OrderedDict from the limited C API. (GH-…
d62b741 
…4900) (#5007)

(cherry picked from commit 1b3029a)
@miss-islington @asvetlov
bpo-26133: Fix typos (GH-5010) (#5014)
32518b4 
* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15)
@serhiy-storchaka
[3.6] bpo-32416: Refactor tests for the f_lineno setter and add new t…
ea98eba 
…ests. (GH-4991). (#5016)

(cherry picked from commit 53f9135)
@miss-islington @Mariatta
bpo-32440: Update the docs URL to https in help() (GH-5030) (GH-5031)
6eb232c 
In pydoc.py, the reference to Python' documentation was in http.
The link has been updated to use https.
(cherry picked from commit e5681b9)
@miss-islington @benjaminp
make PatternCompiler use the packaged grammar if possible (more bpo-2…
85f71aa 
…4960) (GH-5034) (#5036)

(cherry picked from commit e5f7dcc)
@miss-islington @benjaminp
remove unused import (GH-5040) (#5042)
1b2812a 
(cherry picked from commit e325608)
@zware
Add missing backslashes in PCbuild bat files (GH-5056) (GH-5057)
fe90efd 
(cherry picked from commit 6c6d3a4)
@miss-islington @serhiy-storchaka
bpo-32416: Add two new tests in test_sys_settrace. (GH-5072) (#5073)
439ce8a 
Move other test to more proper place.
(cherry picked from commit e8ed965)
@miss-islington @serhiy-storchaka
bpo-32478: Add tests for 'break' and 'return' inside 'finally' clause. (
aea95c2 
GH-5078) (#5083)

(cherry picked from commit 7cc42c3)
@miss-islington @bitdancer
bpo-32452: clarify term 'brackets' in generator tutorial (GH-5079) (#…
f24c185 
…5081)

Updates documentation for generator expressions in classes tutorial: Clarify usage of ambiguous term "brackets" by replacing with "square brackets". Updated subsequent lines to respect line breaks. (GH-5079)
(cherry picked from commit f190eb5)
@serhiy-storchaka
bpo-32211: Document the existing bug in re.findall() and re.finditer(…
1e6d852 
…). (#4695)
@miss-islington @serhiy-storchaka
bpo-32482: Fix suspicious code in tests for syntax and grammar. (GH-5086
a70d5ff 
) (#5095)

(cherry picked from commit 0cc99c8)
@miss-islington @berkerpeksag
Fix outdated comment in typeobject.c (GH-5090)
78e43a5 
The comment was added in 3abca12.
In d78448e, it was changed to
use PyArg_ParseTuple instead.

(cherry picked from commit 78e24d4)
@miss-islington @benjaminp
advance copyright years to 2018 (GH-5094) (#5104)
e295739 
(cherry picked from commit 65f2a6d)
@zware
[3.6] Kill the AppVeyor file whitelist (GH-5122)
157be7c 
It's more trouble than it's worth, since AppVeyor only checks the HEAD commit of a PR rather than the full diff against the base branch to decide which files changed.
(cherry picked from commit 7f7de37)
@miss-islington @serhiy-storchaka
bpo-31802: Fix importing native path module before importing os. (GH-…
94a3fac 
…4017) (#5129)

(cherry picked from commit 3460198)
@zware
Fix version in AppVeyor config (GH-5125)
9c99fd1
@miss-islington @Mariatta
Lexical Analysis ref doc: Fix a typo in the string concatenation inte…
22b1050 
…rnal link (GH-5157) (GH-5160)

In lexical analysis reference documentation, the internal link to
the string literal concatenation section was written as`.. _string-catenation:`.
Changed that to `.. _string-concatenation:`.
(cherry picked from commit 3764bb0)
@miss-islington @methane
bpo-32473: Improve ABCMeta._dump_registry() readability (GH-5091)
a91662a 
(cherry picked from commit ae12f5d)
@miss-islington @tiran
[3.6] bpo-32521: nis libtirpc (GH-5137) (#5165)
d55d682 
glibc has removed Sun RPC. Use replacement libtirpc headers and library in
nis module

Signed-off-by: Christian Heimes <[email protected]>
(cherry picked from commit f3031b8)
@miss-islington @Mariatta
Improve enum.Flag code example (GH-5167) (GH-5171)
29b1aff 
The code example that demonstrate how to use enum.Flag was missing
the import of enum.auto.
(cherry picked from commit 0f31c74)
@miss-islington @rhettinger
Add itertools recipe for directly finding the n-th combination (GH-5161…
cf4cd4b 
…) (#5174)

(cherry picked from commit d37258d)
@miss-islington @Mariatta
bpo-15221: Update os.path.is*() documentation (GH-5185) (GH-5186)
bb80645 
`os.path.is*()` can return False if the file can't be accessed.
The behaviour is documented in details in `os.path.exists()`.
Link to `os.path.exists()` from `os.path.is*()`.
(cherry picked from commit b3dd18d)
@miss-islington @Mariatta
bpo-26330: Update shutil.disk_usage() documentation (GH-5184) (GH-5188)
fb8569e 
Clarify that on Windows, path must be a directory.
On Unix, path can be a file or a directory.
(cherry picked from commit ee3b835)
miss-islington and others added 13 commits April 6, 2018 18:15
@miss-islington @ned-deily
[3.6] bpo-29673: fix gdb scripts pystack and pystackv (GH-6126) (GH-6400
3468a05 
)

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch <[email protected]>
@miss-islington @jcrotts @ned-deily
[3.6] bpo-8243: Doc patch for curses.window.addstr and curses.window.…
70c4446 
…addch (GH-5179) (GH-6406)

(cherry picked from commit ef5ce88)

Co-authored-by: Jay Crotts <[email protected]>
@ned-deily
bpo-33184: Update macOS installer build to use OpenSSL 1.0.2o. (GH-6408)
76215a4
@pitrou
[3.6] bpo-33201: Modernize "Extension types" doc (GH-6337) (GH-6412)
b603609 
* bpo-33201: Modernize "Extension types" doc
* Split tutorial and other topics
* Some small fixes
* Address some review comments
* Rename noddy* to custom* and shoddy to sublist
* Fix markup.
(cherry picked from commit 1d80a56)
@miss-islington @rhettinger
Add a prepend() recipe to teach a chain() idiom (GH-6415) (GH-6422)
280a767 
(cherry picked from commit 9265dd7)

Co-authored-by: Raymond Hettinger <[email protected]>
@miss-islington
Update docstring of tempfile._RandomNameSequence (GH-6414)
335efd7 
When bpo-12015 got resolved by increasing the length of the
random string generated by _RandomNameSequence from six to eight
characters, the docstring of the class was not adjusted accordingly.
(cherry picked from commit 9c463ec)

Co-authored-by: Wolfgang Maier <[email protected]>
@serhiy-storchaka
[3.6] Improve highlighting of some code blocks. (GH-6401). (GH-6424)
1429ac9 
(cherry picked from commit 46936d5)
@miss-islington @serhiy-storchaka
Fix misleading docsting of shelve.open(). (GH-6427)
2d01ac5 
The protocol parameter can be any protocol supported by the
pickle module.
(cherry picked from commit 2ef65f3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @serhiy-storchaka
bpo-31920: Fixed handling directories as arguments in the ``pygettext…
e0dbc57 
…`` script. (GH-6259)

Based on patch by Oleg Krasnikov.
(cherry picked from commit c93938b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @aaronang @ned-deily
[3.6] bpo-31201: Clarify command to re-run failing test(s) with examp…
83bb399 
…le (GH-6417) (GH-6438)

(cherry picked from commit 0f914b5)

Co-authored-by: Aaron Ang <[email protected]>
@miss-islington @Gorialis
bpo-33253: Fix xxsubtype.bench() to accept correct str signature. (GH…
910d71b 
…-6439)

(cherry picked from commit f178028)

Co-authored-by: Devon R <[email protected]>
@miss-islington @suic86
Fix error messages in argparse examples (GH-6435)
e98e338 
The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(cherry picked from commit 04e8293)

Co-authored-by: suic86 <[email protected]>
@arikrupnik
Compliance with DOM L1: return removed attribute
d8c727d 
W3C DOM Level 1[1] requires `removeAttributeNode()` to return the removed node:

removeAttributeNode: Removes the specified attribute.
Return Value: The Attr node that was removed.

Current implementation returns `None`.

[1]https://www.w3.org/TR/1998/REC-DOM-Level-1-19981001/level-one-core.html#method-removeAttributeNode

test cases for Element.testRemoveAttributeNode()
@arikrupnik arikrupnik requested a review from a team June 7, 2018 02:41
@arikrupnik arikrupnik requested a review from a team as a code owner June 7, 2018 02:41
@arikrupnik arikrupnik closed this Jun 7, 2018
@arikrupnik arikrupnik deleted the patch-1 branch June 7, 2018 03:17
@arikrupnik
Copy link
Contributor Author

Tried to open PR from wrong branch. Closing. Correct PR #7465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@gpshead gpshead Awaiting requested review from gpshead

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

@skrah skrah Awaiting requested review from skrah

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.