Skip to content

bpo-31201: Clarify command to re-run failing test(s) with example #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2018

Conversation

aaronang
Copy link
Contributor

@aaronang aaronang commented Apr 8, 2018

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

README.rst Outdated

make test TESTOPTS="-v test_that_failed"
make test TESTOPTS="-v test_os test_gdb"
Copy link
Member

@ned-deily ned-deily Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the (additional) preceding space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice catch.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aaronang
Copy link
Contributor Author

aaronang commented Apr 9, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Thanks @aaronang for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6437 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 9, 2018
@bedevere-bot
Copy link

GH-6438 is a backport of this pull request to the 3.6 branch.

ned-deily pushed a commit that referenced this pull request Apr 9, 2018
ned-deily pushed a commit that referenced this pull request Apr 9, 2018
@aaronang aaronang deleted the bpo-31201 branch April 10, 2018 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants