Skip to content

bpo-29673: Some gdb macros are broken in 3.6 #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Apr 6, 2018
Merged

bpo-29673: Some gdb macros are broken in 3.6 #6126

merged 1 commit into from Apr 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2018 •
edited by bedevere-bot
Loading

This PR fixes broken scripts for printing of Python call stack from GDB.

https://bugs.python.org/issue29673

@ghost ghost changed the title fix gdb scripts pystack and pystackv bpo-29673: ome gdb macros are broken in 3.6 Mar 16, 2018
@ghost ghost changed the title bpo-29673: ome gdb macros are broken in 3.6 bpo-29673: Some gdb macros are broken in 3.6 Mar 16, 2018
ned-deily
ned-deily reviewed Apr 4, 2018
View reviewed changes
Misc/NEWS.d/next/Tools-Demos/2018-03-16-17-25-05.bpo-29673.m8QtaW.rst Outdated
@@ -0,0 +1,20 @@
Fix gdbinit
Copy link
Member

@ned-deily ned-deily Apr 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a NEWS entry. However, this is a bit too detailed. See a current changelog to get a sense of the level of detail we use. This kind of detail might be appropriate for a commit message.

smontanaro
smontanaro reviewed Apr 5, 2018
View reviewed changes
Copy link
Contributor

@smontanaro smontanaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo Ned's NEWS file comment. (I am really surprised this little hack has lived this long...)

ned-deily
ned-deily requested changes Apr 5, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @smontanaro , and the changes, @Traceur759. Almost there!

Misc/ACKS Outdated
@@ -1806,3 +1806,4 @@ Jelle Zijlstra
Gennadiy Zlobin
Doug Zongker
Peter Åstrand
Marcel Plch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: we try to keep the ACKs list in alphabetical order by family name. So please insert your name in the "P" section. Thanks!

Misc/NEWS.d/next/Tools-Demos/2018-03-16-17-25-05.bpo-29673.m8QtaW.rst Outdated
@@ -0,0 +1,6 @@
PyUnicode_AsString() was removed in Python and PyUnicode_AsUTF8() is now used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for condensing the NEWS entry. But I think it is still too detailed and does not really answer the question of what was fixed; why it was fixed is not so important here. Also, if you wish, you can add your name here. An example from the Developer's Guide:

Fix warning message when os.chdir() fails inside
test.support.temp_cwd(). Patch by Chris Jerdonek.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ghost
Copy link
Author

ghost commented Apr 6, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@ned-deily ned-deily merged commit 3a9ccee into python:master Apr 6, 2018
@miss-islington
Copy link
Contributor

Thanks @Traceur759 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6399 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2018
@miss-islington
bpo-29673: fix gdb scripts pystack and pystackv (pythonGH-6126)
5427d0e 
(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2018
@miss-islington
bpo-29673: fix gdb scripts pystack and pystackv (pythonGH-6126)
155fc95 
(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch <[email protected]>
@bedevere-bot
Copy link

GH-6400 is a backport of this pull request to the 3.6 branch.

ned-deily pushed a commit that referenced this pull request Apr 6, 2018
@miss-islington @ned-deily
[3.7] bpo-29673: fix gdb scripts pystack and pystackv (GH-6126) (GH-6399
3c193cf 
)

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch <[email protected]>
ned-deily pushed a commit that referenced this pull request Apr 6, 2018
@miss-islington @ned-deily
[3.6] bpo-29673: fix gdb scripts pystack and pystackv (GH-6126) (GH-6400
3468a05 
)

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bedevere-bot @miss-islington @smontanaro @ned-deily @the-knights-who-say-ni