bpo-33253: Fix xxsubtype.bench to accept correct string signature #6439
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
serhiy-storchaka
added
type-bug
|
Thanks @Gorialis for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6440 is a backport of this pull request to the 3.7 branch. |
…thonGH-6439) (cherry picked from commit f178028) Co-authored-by: Devon R <[email protected]>
…thonGH-6439) (cherry picked from commit f178028) Co-authored-by: Devon R <[email protected]>
|
GH-6441 is a backport of this pull request to the 3.6 branch. |
|
Thank you for your contribution @Gorialis! Signing the CLA is not required for such trivial change. But it would be better to sign it for the case if you will contribute less trivial changes in future. |
…-6439) (cherry picked from commit f178028) Co-authored-by: Devon R <[email protected]>
…-6439) (cherry picked from commit f178028) Co-authored-by: Devon R <[email protected]>
This fixes the issue as explained on the tracker where
xxsubtype.benchcan never run without raising an exception due to the old Python 2 string signature still being in use.Old behavior:
New behavior:
https://bugs.python.org/issue33253