bpo-8243: Doc patch for curses.window.addstr and curses.window.addch #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrixise
requested changes
Jan 30, 2018
Doc/library/curses.rst
Outdated
|
|
||
| Writing outside the window, subwindow, or pad raises :exc:`curses.error`. | ||
| Attempting to write to the lower right corner of a window, subwindow, | ||
| or pad will cause an exception to be raised after the character is printed. |
There was a problem hiding this comment.
replace after the caracter is printed by after the string is printed
|
Could you rebase your commits ? 5 commits should become 1 commit. Thank you, |
|
Sure, I will make the change, and then rebase. |
|
Okay, I made the changes, and rebased my commits. Thanks for the help. |
ned-deily
added
needs backport to 3.6
docs
|
Thanks @jcrotts for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-6404 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2018
…ythonGH-5179) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
|
GH-6405 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2018
…ythonGH-5179) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 7, 2018
…ythonGH-5179) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
|
GH-6406 is a backport of this pull request to the 3.6 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Apr 7, 2018
…addch (GH-5179) (GH-6404) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Apr 7, 2018
…addch (GH-5179) (GH-6406) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Apr 7, 2018
…addch (GH-5179) (GH-6405) (cherry picked from commit ef5ce88) Co-authored-by: Jay Crotts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-8243: Doc patch for curses.window.addstr and curses.window.addch
Added documentation notes for two functions in curses.window .
This is my first pr, please let me know what else I need to do.
https://bugs.python.org/issue8243