Skip to content

Fix error messages in argparse examples. #6435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

suic86
Copy link
Contributor

@suic86 suic86 commented Apr 9, 2018

This change replaces error: too few arguments error message in examples in argparse documentation for Python 3.x with error: the following arguments are required:. The error: too few arguments was removed in this commit f97c59a in 2011.

The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(see python@f97c59a)
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@suic86
Copy link
Contributor Author

suic86 commented Apr 9, 2018

I've signed CLA already twice and I tried to resubmit this PR but the bot is still saying that CLA not signed. This is really annoying :/

@chadmiller-amzn
Copy link

bugs.p.o has a list of bugs accounts that have signed the CLA, each of which might have a github account in it. If the CLA check can map your github name back to a bugs account that has signed the CLA, then you shouldn't see this.

If it doesn't work, you should file a bug report on that.

@suic86
Copy link
Contributor Author

suic86 commented Apr 11, 2018

@chadmiller-amzn thanks for the information. My CLA is now logged and I can see in my b.p.o profile. Could someone remove the CLA Not Signed label? Thanks

@zware zware merged commit 04e8293 into python:master Apr 11, 2018
@miss-islington
Copy link
Contributor

Thanks @suic86 for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@zware
Copy link
Member

zware commented Apr 11, 2018

Thanks, @suic86!

@bedevere-bot
Copy link

GH-6451 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2018
The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(cherry picked from commit 04e8293)

Co-authored-by: suic86 <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2018
The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(cherry picked from commit 04e8293)

Co-authored-by: suic86 <[email protected]>
@bedevere-bot
Copy link

GH-6452 is a backport of this pull request to the 3.6 branch.

@suic86
Copy link
Contributor Author

suic86 commented Apr 11, 2018

Thanks, @zware! :)

@suic86 suic86 deleted the fix-argparse-examples branch April 11, 2018 18:53
miss-islington added a commit that referenced this pull request Apr 11, 2018
The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(cherry picked from commit 04e8293)

Co-authored-by: suic86 <[email protected]>
miss-islington added a commit that referenced this pull request Apr 11, 2018
The examples in argparse documentation use `error: too few arguments`
error message which was removed in this commit f97c59a in 2011.
(cherry picked from commit 04e8293)

Co-authored-by: suic86 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants