Skip to content

[SDK] Perf improvements for erc-20 methods #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 24, 2023
Merged

[SDK] Perf improvements for erc-20 methods #1814

merged 13 commits into from
Oct 24, 2023

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 20, 2023

Problem solved

Continue work for #1648

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@kien-ngo kien-ngo requested a review from a team October 20, 2023 05:32
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 53298a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo kien-ngo marked this pull request as draft October 20, 2023 16:35
@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/common/any-evm-constants.ts 100.00% <ø> (ø)
...m/common/any-evm-utils/getCreate2FactoryAddress.ts 85.71% <ø> (ø)
.../sdk/src/evm/core/classes/erc-20-batch-mintable.ts 100.00% <100.00%> (ø)
...ckages/sdk/src/evm/core/classes/erc-20-burnable.ts 92.85% <ø> (ø)
...ackages/sdk/src/evm/core/classes/erc-20-history.ts 84.61% <100.00%> (+1.28%) ⬆️
...ckages/sdk/src/evm/core/classes/erc-20-mintable.ts 100.00% <ø> (ø)
...c/evm/common/any-evm-utils/deployCreate2Factory.ts 78.78% <60.00%> (-1.22%) ⬇️
...n/any-evm-utils/getCreate2FactoryDeploymentInfo.ts 80.00% <0.00%> (-8.89%) ⬇️
...ackages/sdk/src/evm/core/classes/contract-roles.ts 85.71% <84.61%> (-0.37%) ⬇️
.../src/evm/core/classes/erc-20-signature-mintable.ts 96.61% <91.66%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@kien-ngo kien-ngo marked this pull request as ready for review October 20, 2023 22:26
@kien-ngo kien-ngo removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 20, 2023
@kien-ngo kien-ngo added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit db0bbf5 Oct 24, 2023
@kien-ngo kien-ngo deleted the kien/chore-20 branch October 24, 2023 04:50
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
IDubuque pushed a commit that referenced this pull request Oct 31, 2023
IDubuque pushed a commit that referenced this pull request Nov 9, 2023
[RN] Update weights (#1817)

[RN] i18n more strings and fix fontFamily (#1818)

[RN] i18n strings (#1819)

[RN] Allow custom fontFamily (#1820)

[SmartWallet] implement multidimensional nonces for smart wallets (#1821)

[wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815)

[SDK] Perf improvement for erc-1155-signature-mintable (#1824)

[wallets, react] Add OKX wallet (#1826)

Version Packages (#1793)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[SDK] Improve contract-roles methods (#1798)

Spicy chain gas override (#1805)

Use BigInt function instead of bigint primitive numbers (#1830)

[RN] Allows for custom auth with embeddedWallet (#1806)

[RN] Update changelog (#1833)

[SDK] Perf improvements for erc-20 methods (#1814)

Signed-off-by: Kien Ngo <[email protected]>

[SDK] Add ERC6551 Interface (#1324)

Co-authored-by: ikethirdweb <[email protected]>
Co-authored-by: Joaquim Verges <[email protected]>

Patch: missing data arg in isSmartWalletDeployed (#1840)

[RN] Update naming for embeddedWallet jwt flow (#1841)

[SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827)

Signed-off-by: Kien Ngo <[email protected]>

[RN] Migrate embedded wallet to new api (#1844)

[SDK] Fix double trailing slash when downloading merkle data (#1850)

chore(chains): sync chains (#1843)

Signed-off-by: Jonas Daniels <[email protected]>

[Wallet] Fix getSmartWalletAddress util function (#1851)

[wallets] - Fix chains package not tree-shaken because of SmartWallet  (#1853)

[SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854)

Fix typo in comments (#1839)

Signed-off-by: vuittont60 <[email protected]>

feat: Update minimum required Node version to 18.17.0 (#1855)

[SmartWallet] Expose new estimation functions for smart wallet transactions (#1856)

feat: Update minimum required Node.js version to >=18 (#1858)

Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859)

Version Packages (#1828)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(chains): sync chains (#1865)

[SmartWallet] expose data in smart wallet utils (#1867)

Version Packages (#1866)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[WALLET + REACT] Add Cometh Connect (#1749)

Signed-off-by: Manan Tank <[email protected]>
Co-authored-by: Manan Tank <[email protected]>
Co-authored-by: Joaquim Verges <[email protected]>

Revert "[WALLET + REACT] Add Cometh Connect" (#1879)

[SDK] Lazy load JSON files (#1862)

Signed-off-by: Kien Ngo <[email protected]>

[RN] Adds Japanese and Spanish support (#1878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants