Skip to content

[wallets, react] expose onAuthSuccess callback in paperWallet #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

ElasticBottle
Copy link
Contributor

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: add onAuthSuccess optional callback to paperWallet
  • Internal API changes: None

How to test

  • Automated tests: None
  • Manual tests: install in test dapp and test

@ElasticBottle ElasticBottle requested a review from a team as a code owner October 20, 2023 12:18
@ElasticBottle ElasticBottle requested a review from a team October 20, 2023 12:18
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 8ceb207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/react Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ElasticBottle ElasticBottle changed the title Winston/expose onauth callback [wallets, react] expose onauth callback Oct 20, 2023
@ElasticBottle ElasticBottle changed the title [wallets, react] expose onauth callback [wallets, react] expose onAuthSuccess callback in paperWallet Oct 20, 2023
@ElasticBottle ElasticBottle added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 20, 2023
@ElasticBottle
Copy link
Contributor Author

/release-pr

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/common/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/evm/common/legacy.ts 100.00% <100.00%> (ø)
packages/sdk/src/evm/common/parseSnapshotInputs.ts 100.00% <100.00%> (ø)
...sdk/src/evm/common/plugin/getCompositePluginABI.ts 75.00% <100.00%> (ø)
packages/sdk/src/evm/common/sign.ts 42.85% <ø> (ø)
.../contracts/prebuilt-implementations/marketplace.ts 73.75% <100.00%> (ø)
...ntracts/prebuilt-implementations/nft-collection.ts 89.85% <ø> (ø)
...src/evm/contracts/prebuilt-implementations/pack.ts 67.66% <100.00%> (-0.39%) ⬇️
...rc/evm/contracts/prebuilt-implementations/split.ts 86.17% <100.00%> (-0.70%) ⬇️
...sdk/src/evm/core/classes/erc-721-batch-mintable.ts 92.59% <ø> (ø)
... and 7 more

📢 Thoughts on this report? Let us know!.

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits

@ElasticBottle ElasticBottle removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 20, 2023
@ElasticBottle ElasticBottle added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit 5ffbcfc Oct 21, 2023
@ElasticBottle ElasticBottle deleted the winston/expose-onauth-callback branch October 21, 2023 01:07
@github-actions github-actions bot mentioned this pull request Oct 21, 2023
IDubuque pushed a commit that referenced this pull request Nov 9, 2023
[RN] Update weights (#1817)

[RN] i18n more strings and fix fontFamily (#1818)

[RN] i18n strings (#1819)

[RN] Allow custom fontFamily (#1820)

[SmartWallet] implement multidimensional nonces for smart wallets (#1821)

[wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815)

[SDK] Perf improvement for erc-1155-signature-mintable (#1824)

[wallets, react] Add OKX wallet (#1826)

Version Packages (#1793)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[SDK] Improve contract-roles methods (#1798)

Spicy chain gas override (#1805)

Use BigInt function instead of bigint primitive numbers (#1830)

[RN] Allows for custom auth with embeddedWallet (#1806)

[RN] Update changelog (#1833)

[SDK] Perf improvements for erc-20 methods (#1814)

Signed-off-by: Kien Ngo <[email protected]>

[SDK] Add ERC6551 Interface (#1324)

Co-authored-by: ikethirdweb <[email protected]>
Co-authored-by: Joaquim Verges <[email protected]>

Patch: missing data arg in isSmartWalletDeployed (#1840)

[RN] Update naming for embeddedWallet jwt flow (#1841)

[SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827)

Signed-off-by: Kien Ngo <[email protected]>

[RN] Migrate embedded wallet to new api (#1844)

[SDK] Fix double trailing slash when downloading merkle data (#1850)

chore(chains): sync chains (#1843)

Signed-off-by: Jonas Daniels <[email protected]>

[Wallet] Fix getSmartWalletAddress util function (#1851)

[wallets] - Fix chains package not tree-shaken because of SmartWallet  (#1853)

[SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854)

Fix typo in comments (#1839)

Signed-off-by: vuittont60 <[email protected]>

feat: Update minimum required Node version to 18.17.0 (#1855)

[SmartWallet] Expose new estimation functions for smart wallet transactions (#1856)

feat: Update minimum required Node.js version to >=18 (#1858)

Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859)

Version Packages (#1828)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore(chains): sync chains (#1865)

[SmartWallet] expose data in smart wallet utils (#1867)

Version Packages (#1866)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[WALLET + REACT] Add Cometh Connect (#1749)

Signed-off-by: Manan Tank <[email protected]>
Co-authored-by: Manan Tank <[email protected]>
Co-authored-by: Joaquim Verges <[email protected]>

Revert "[WALLET + REACT] Add Cometh Connect" (#1879)

[SDK] Lazy load JSON files (#1862)

Signed-off-by: Kien Ngo <[email protected]>

[RN] Adds Japanese and Spanish support (#1878)
jnsdls added a commit that referenced this pull request Jun 19, 2024
* feat: Add Engine tab to dashboard

* A lot of stuff? Config done

* Backend wallets table

* Add import/create backend wallet capabilities

* Update margin

* Filter txns by chain id

* Add balance check

* Fix build

* Add functions

* Only show remove config if not on local

* whoops

* Add tracking for set wallet config

* Try again

* Update schema for txns

* Update design, save URL in local storage

* Add trailing slash always

* Always simplify url

* Auth works

* Add admin grant/revoke

* Reshuffle stuff

* Add access tokens capabilities

* Add webhooks capabilities

* General updates

* Add local config

* Renaming and moving stuff around

* Hide tab

---------

Co-authored-by: Phillip Ho <[email protected]>
Co-authored-by: Jonas Daniels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants