[SDK] Add ERC6551 Interface #1324

ciaranightingale · 2023-07-12T14:10:34Z

No description provided.

changeset-bot · 2023-07-12T14:10:38Z

🦋 Changeset detected

Latest commit: c9616ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch
thirdweb	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react-native	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/react-native-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/wallets/src/evm/connectors/smart-wallet/index.ts

iketw · 2023-07-21T16:48:56Z

packages/wallets/src/evm/wallets/token-bound-smart-wallet.ts

+
+    static id = walletIds.tokenBoundSmartWallet;
+    public get walletName() {
+        return "Token Bound Smart Wallet" as "Smart Wallet";


Can you remove the as part? Was there a type error?

Yes, type error

iketw · 2023-07-21T16:52:35Z

packages/wallets/src/evm/wallets/smart-wallet.ts

-  constructor(options: WalletOptions<SmartWalletConfig>) {
-    super(SmartWallet.id, {
+  constructor(options: WalletOptions<SmartWalletConfig>, id?: string) {
+    super(id || SmartWallet.id, {


Here, instead of adding a new id params, you can use the walletId param in the options object. You can change this code to be:

super(options.walletId || SmartWallet.id, {

I added this to reflect these changes as well in token-bound-smart-wallet.ts:

constructor(options: WalletOptions<TokenBoundSmartWalletConfig>) { options.walletId = walletIds.tokenBoundSmartWallet; super(options ); }

iketw · 2023-07-21T16:56:07Z

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

+    }
+
+    async initialize(personalWallet: EVMWallet) {
+        const factoryAddress = this.config.factoryAddress || "0x02101dfB77FDE026414827Fdc604ddAF224F0921";


Should we remove this default value since users need to pass a factoryAddress here?

If they don't pass a factory address, we want them to use the ERRC-6551 official registry (this makes it a token bound account as they have claimed the term)

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

iketw · 2023-07-21T17:01:58Z

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

+
+    async initialize(personalWallet: EVMWallet) {
+        const factoryAddress = this.config.factoryAddress || "0x02101dfB77FDE026414827Fdc604ddAF224F0921";
+        await super.initialize(personalWallet, factoryAddress);


Can the factoryAddress be changed once you do new TokenBoundConnnector ? If it cannot be changed then there's no need to pass this extra factoryAddress param here; initialize will just use whatever it was passed in the config

The behaviour I was trying to achieve here was to allow users to pass a factory address if they prefer but to provide the 6551 official address by default

I was following the same format as bundlerUrl etc

iketw · 2023-07-21T17:03:27Z

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

+                return account.prepare("executeCall", [target, value, data]);
+            },
+            getNonce: async (account) => {
+                return account.call("nonce", []);


Dumb question but in the parent SmartWallet class, the calls here are: execute and getNonce, just making sure these are different on purpose

Yeah in the official registry, the function signatures are different - they are of this format

Can you double check that these can be configured back if they so choose

@joaquim-verges could you check this please - my assumption was to use the erc-6551 registry function signatures by default rather than the ones we have - is this the route we are choosing to go? SHould we have a custom option or something which uses the thirdweb defaults? I just wanted to keep things simple but I'm not sure

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

…iara/tba Merge remote

Merge main

codecov · 2023-07-24T16:54:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

see 138 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

…iara/tba

packages/wallets/src/evm/connectors/token-bound-smart-wallet/index.ts

packages/wallets/src/evm/connectors/smart-wallet/types.ts

packages/wallets/src/evm/connectors/token-bound-smart-wallet/types.ts

joaquim-verges · 2023-08-09T19:27:59Z

/release-pr

packages/wallets/src/evm/connectors/smart-wallet/types.ts

ciaranightingale · 2023-09-15T16:19:30Z

/release-pr

ciaranightingale · 2023-09-15T16:22:51Z

/release-pr

nkrishang · 2023-09-15T16:47:11Z

/release-pr

Co-authored-by: ikethirdweb <[email protected]> Co-authored-by: Joaquim Verges <[email protected]>

[RN] Update weights (#1817) [RN] i18n more strings and fix fontFamily (#1818) [RN] i18n strings (#1819) [RN] Allow custom fontFamily (#1820) [SmartWallet] implement multidimensional nonces for smart wallets (#1821) [wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815) [SDK] Perf improvement for erc-1155-signature-mintable (#1824) [wallets, react] Add OKX wallet (#1826) Version Packages (#1793) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [SDK] Improve contract-roles methods (#1798) Spicy chain gas override (#1805) Use BigInt function instead of bigint primitive numbers (#1830) [RN] Allows for custom auth with embeddedWallet (#1806) [RN] Update changelog (#1833) [SDK] Perf improvements for erc-20 methods (#1814) Signed-off-by: Kien Ngo <[email protected]> [SDK] Add ERC6551 Interface (#1324) Co-authored-by: ikethirdweb <[email protected]> Co-authored-by: Joaquim Verges <[email protected]> Patch: missing data arg in isSmartWalletDeployed (#1840) [RN] Update naming for embeddedWallet jwt flow (#1841) [SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827) Signed-off-by: Kien Ngo <[email protected]> [RN] Migrate embedded wallet to new api (#1844) [SDK] Fix double trailing slash when downloading merkle data (#1850) chore(chains): sync chains (#1843) Signed-off-by: Jonas Daniels <[email protected]> [Wallet] Fix getSmartWalletAddress util function (#1851) [wallets] - Fix chains package not tree-shaken because of SmartWallet (#1853) [SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854) Fix typo in comments (#1839) Signed-off-by: vuittont60 <[email protected]> feat: Update minimum required Node version to 18.17.0 (#1855) [SmartWallet] Expose new estimation functions for smart wallet transactions (#1856) feat: Update minimum required Node.js version to >=18 (#1858) Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859) Version Packages (#1828) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> chore(chains): sync chains (#1865) [SmartWallet] expose data in smart wallet utils (#1867) Version Packages (#1866) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [WALLET + REACT] Add Cometh Connect (#1749) Signed-off-by: Manan Tank <[email protected]> Co-authored-by: Manan Tank <[email protected]> Co-authored-by: Joaquim Verges <[email protected]> Revert "[WALLET + REACT] Add Cometh Connect" (#1879) [SDK] Lazy load JSON files (#1862) Signed-off-by: Kien Ngo <[email protected]> [RN] Adds Japanese and Spanish support (#1878)

ciaranightingale added 3 commits July 5, 2023 09:01

wip

7524d7a

merge main

de65f04

wip

98c7018

ciaranightingale added DO NOT MERGE This pull request is still in progress and is not ready to be merged. CLI CLI-related changes labels Jul 12, 2023

ciaranightingale requested a review from a team July 12, 2023 14:10

Merge branch 'main' into ciara/tba

820d4cc

ciaranightingale marked this pull request as draft July 12, 2023 14:11

ciaranightingale requested a review from joaquim-verges July 12, 2023 14:11

iketw reviewed Jul 21, 2023

View reviewed changes

ciaranightingale added 6 commits July 24, 2023 15:39

merge main

4755ac0

wip

2580d13

update with clientId & secretKey & requested changes

279b260

Merge branch 'ciara/tba' of https://github.com/thirdweb-dev/js into c…

c8445b9

…iara/tba Merge remote

Merge branch 'main' into ciara/tba

af57f47

Merge main

fix build

2db5249

ciaranightingale added 3 commits July 26, 2023 17:48

wip

73a51fa

wip

39e22b9

Merge branch 'ciara/tba' of https://github.com/thirdweb-dev/js into c…

f34654b

…iara/tba

ciaranightingale requested a review from iketw July 26, 2023 19:18

restructure

7477b73

joaquim-verges reviewed Jul 26, 2023

View reviewed changes

joaquim-verges and others added 3 commits July 26, 2023 17:29

cleanup

5ab826b

Merge branch 'main' into ciara/tba

909ca2f

Merge branch 'main' into ciara/tba

0c9ada2

ciaranightingale removed the CLI CLI-related changes label Jul 27, 2023

working code & fix factoryAddress required

cf5bb93

ciaranightingale requested a review from joaquim-verges July 27, 2023 20:55

Merge branch 'main' into ciara/tba

fdee3f5

Merge branch 'main' into ciara/tba

0bdddc0

joaquim-verges reviewed Sep 8, 2023

View reviewed changes

packages/wallets/src/evm/connectors/smart-wallet/types.ts Outdated Show resolved Hide resolved

ciaranightingale marked this pull request as ready for review September 15, 2023 16:15

joaquim-verges added 2 commits October 13, 2023 16:46

Merge branch 'main' into ciara/tba

f11c12a

fix types

e93da7f

joaquim-verges force-pushed the ciara/tba branch from 58232dd to e93da7f Compare October 14, 2023 03:50

joaquim-verges added 2 commits October 13, 2023 20:57

linting

6b4642a

fix build

8a07db2

joaquim-verges requested a review from a team as a code owner October 14, 2023 04:05

joaquim-verges added 3 commits October 23, 2023 21:25

Merge branch 'main' into ciara/tba

a8464f6

require account impl for now

4c8dd1c

changeset

c9616ed

joaquim-verges removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 24, 2023

joaquim-verges enabled auto-merge October 24, 2023 04:41

joaquim-verges added this pull request to the merge queue Oct 24, 2023

Merged via the queue into main with commit 4cb6e28 Oct 24, 2023

joaquim-verges deleted the ciara/tba branch October 24, 2023 04:55

github-actions bot mentioned this pull request Oct 24, 2023

Version Packages #1828

Merged

IDubuque pushed a commit that referenced this pull request Oct 31, 2023

[SDK] Add ERC6551 Interface (#1324)

3f0cad9

Co-authored-by: ikethirdweb <[email protected]> Co-authored-by: Joaquim Verges <[email protected]>

[SDK] Add ERC6551 Interface #1324

[SDK] Add ERC6551 Interface #1324

Uh oh!

Conversation

ciaranightingale commented Jul 12, 2023

Uh oh!

changeset-bot bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquim-verges commented Aug 9, 2023

Uh oh!

Uh oh!

ciaranightingale commented Sep 15, 2023

Uh oh!

ciaranightingale commented Sep 15, 2023

Uh oh!

nkrishang commented Sep 15, 2023

Uh oh!

Uh oh!

changeset-bot bot commented Jul 12, 2023 •

edited

Loading

codecov bot commented Jul 24, 2023 •

edited

Loading