Fix typo in comments #1839
Merged
Fix typo in comments #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 915ec6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@vuittont60 thanks for the help 🙌 |
|
@vuittont60 Can you add a changeset by running This should be a |
|
@kien-ngo I added the changeset, and is that right? Please help me to review again. Thank you very much. |
Signed-off-by: vuittont60 <[email protected]>
|
Looks good ty @vuittont60 Someone will merge this PR soon. |
Merged
joaquim-verges
pushed a commit
that referenced
this pull request
Oct 27, 2023
Signed-off-by: vuittont60 <[email protected]>
IDubuque
pushed a commit
that referenced
this pull request
Oct 31, 2023
Signed-off-by: vuittont60 <[email protected]>
IDubuque
pushed a commit
that referenced
this pull request
Nov 9, 2023
[RN] Update weights (#1817) [RN] i18n more strings and fix fontFamily (#1818) [RN] i18n strings (#1819) [RN] Allow custom fontFamily (#1820) [SmartWallet] implement multidimensional nonces for smart wallets (#1821) [wallets, react] expose `onAuthSuccess` callback in `paperWallet` (#1815) [SDK] Perf improvement for erc-1155-signature-mintable (#1824) [wallets, react] Add OKX wallet (#1826) Version Packages (#1793) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [SDK] Improve contract-roles methods (#1798) Spicy chain gas override (#1805) Use BigInt function instead of bigint primitive numbers (#1830) [RN] Allows for custom auth with embeddedWallet (#1806) [RN] Update changelog (#1833) [SDK] Perf improvements for erc-20 methods (#1814) Signed-off-by: Kien Ngo <[email protected]> [SDK] Add ERC6551 Interface (#1324) Co-authored-by: ikethirdweb <[email protected]> Co-authored-by: Joaquim Verges <[email protected]> Patch: missing data arg in isSmartWalletDeployed (#1840) [RN] Update naming for embeddedWallet jwt flow (#1841) [SDK] Remove barrel files in `@r\packages\sdk\src\evm` (#1827) Signed-off-by: Kien Ngo <[email protected]> [RN] Migrate embedded wallet to new api (#1844) [SDK] Fix double trailing slash when downloading merkle data (#1850) chore(chains): sync chains (#1843) Signed-off-by: Jonas Daniels <[email protected]> [Wallet] Fix getSmartWalletAddress util function (#1851) [wallets] - Fix chains package not tree-shaken because of SmartWallet (#1853) [SDK/Wallets] Override crypto-js to use latest version to fix vulnera… (#1854) Fix typo in comments (#1839) Signed-off-by: vuittont60 <[email protected]> feat: Update minimum required Node version to 18.17.0 (#1855) [SmartWallet] Expose new estimation functions for smart wallet transactions (#1856) feat: Update minimum required Node.js version to >=18 (#1858) Revert "[SDK/Wallets] Override crypto-js to use latest version to fix vulnera…" (#1859) Version Packages (#1828) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> chore(chains): sync chains (#1865) [SmartWallet] expose data in smart wallet utils (#1867) Version Packages (#1866) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [WALLET + REACT] Add Cometh Connect (#1749) Signed-off-by: Manan Tank <[email protected]> Co-authored-by: Manan Tank <[email protected]> Co-authored-by: Joaquim Verges <[email protected]> Revert "[WALLET + REACT] Add Cometh Connect" (#1879) [SDK] Lazy load JSON files (#1862) Signed-off-by: Kien Ngo <[email protected]> [RN] Adds Japanese and Spanish support (#1878)
jnsdls
added a commit
that referenced
this pull request
Jun 19, 2024
* feature(payments): initialize GQL and page structure * initialize apollo provider * port over .graphql files and fix up generation * fix codegen * .ts files are fine for hooks * feat: add credentials option to ApolloClient * .env.example update * Get payments seller id from api server in fetchAuthToken (#1839) Get paymentsSellerId from api server in fetchAuthToken * Push up example with `paymentsSellerId` * Remove console.logs * Move to component to compile * Render all contracts table (filtered) * Enable payments button * Abstract a bit * Add graphql query to usePayments * Get analytics * Add parsedOverview * Fix prettier * Create checkout logic * Create checkout form shenanigans * Some UI massaging * A bit more * Enable payments redirect * Work for erc1155, disable cache * yes * Some progress with cache? :D * loglog * Fix tracking * Abstract remove button * We're doing it backwards * Cast to number * whoops * Edit checkout logic plz * Empty state * plz * Fix for real * Default * Filter contracts, some more empty states * Moar empty states * Error flow * More empty states, less foot shooting * Get contract name for payment-enabled contracts * Filter default checkout, show contractId * Fix url redirect * whoops * Fix logic * feature: added checkout seller account settings to dashboard (#1931) Signed-off-by: Juan Leal <[email protected]> Signed-off-by: Juan Leal <[email protected]> Signed-off-by: Juan Leal <[email protected]> Co-authored-by: easyrun42 <[email protected]> Signed-off-by: Juan Leal <[email protected]> Co-authored-by: Juan Leal <[email protected]> Co-authored-by: easyrun42 <[email protected]> * invalidateQueries onSuccess * Revert prior change and add apollo refetch() * Try network-only * Add for contracts as well * wip * API Keys capabilities yay * Remove network-only policy * Use lazy queries * Fix api keys * isLoading states * All the cache * now * Rename * Big wip * Fix date picker * chore: added thirdweb_client_id to checkout fragment (#1957) * stuff * Ensure accountId * Copy * Fix mutation * Fix loading states * wip * Kyb shenanigans * Kyc shenanigans :D * More kyc shenanigans * Fix file uploader? * Annoying response * RPC url pls * Remove unused imports * Nope * Lots of checks * Fix kyb check * Kyc improvements * Moar * hid hid * Move around * Nope * Cache? * Lowercase * Webhooks file * Add more supported chains * Full * Fix RPC url * Update contractArgs * Much better * Error state * Validation for URL * Allow empty string * Improve KYB experience * Add compliance email * Fix upload to cloudflare * Add preview button * Improve preview * Okay * Fix font weight * Just because * Use the Preview environment for workflows * Pass environment var name context through * syntax update * Test - show public env var * syntax * See if public variable makes it through * Add public api * Use secrets instead of vars * Remove test --------- Signed-off-by: Jonas Daniels <[email protected]> Signed-off-by: Edward Sun <[email protected]> Signed-off-by: Juan Leal <[email protected]> Co-authored-by: Jonas Daniels <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: gerrysaporito <[email protected]> Co-authored-by: Juan Leal <[email protected]> Co-authored-by: easyrun42 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in comments