Skip to content

[SDK] Perf improvements with Promise.all #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 37 commits into from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 25, 2023

Don't merge this

I'm aware this is a lot of changes. I will probably split it up into smaller PRs so that we have more control

Problem solved

We have a lot of Promise.all that are not calling the inner requests concurrently, rather sequencially.

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Self note: The following Pormise.all in this file can be improved however it seems too complex dont wanna touch that rn

  • packages\sdk\src\evm\core\classes\drop-erc1155-claim-conditions.ts
  • packages\sdk\src\evm\common\claim-conditions\processClaimConditionInputs.ts
  • packages\sdk\src\evm\common\any-evm-utils\computeDeploymentInfo.ts

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

⚠️ No Changeset found

Latest commit: 8fce178

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kien-ngo kien-ngo changed the title [SDK] Perf improvements for Promise.all [SDK] Perf improvements for Promise.all <Don't merge this> Sep 26, 2023
@kien-ngo kien-ngo mentioned this pull request Sep 26, 2023
4 tasks
@kien-ngo kien-ngo changed the title [SDK] Perf improvements for Promise.all <Don't merge this> [SDK] Perf improvements with Promise.all <DO NOT MERGE> Sep 26, 2023
@kien-ngo kien-ngo mentioned this pull request Sep 26, 2023
4 tasks
@kien-ngo
Copy link
Contributor Author

kien-ngo commented Sep 27, 2023

Self note: The following files are to be cleaned up/improved

image

@kien-ngo kien-ngo changed the title [SDK] Perf improvements with Promise.all <DO NOT MERGE> [SDK] Perf improvements with Promise.all Oct 4, 2023
kien-ngo added a commit that referenced this pull request Oct 7, 2023
@kien-ngo
Copy link
Contributor Author

kien-ngo commented Nov 8, 2023

Most changes are published. Happy to close this

@kien-ngo kien-ngo closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This pull request is still in progress and is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants