-
Notifications
You must be signed in to change notification settings - Fork 440
Cherry-pick multiple PRs to release/5.9
#1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ahoppen
merged 22 commits into
swiftlang:release/5.9
from
ahoppen:ahoppen/5.9/cherry-pick-2
Apr 22, 2023
Merged
Cherry-pick multiple PRs to release/5.9
#1556
ahoppen
merged 22 commits into
swiftlang:release/5.9
from
ahoppen:ahoppen/5.9/cherry-pick-2
Apr 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-utf8 Document that `Trivia` cannot represent invalid UTF-8
…warning fix XCTSkip warning
…blic-api Audit the public API of the SwiftSyntax module
Remove warning
…l-escape Fix escape handling for emoji `#️⃣` in string literals
…ies_diagnostics Split DeclEffectSpecifiers into AccessorEffectSpecifiers and FunctionEffectSpecifiers
Add whitespace before `else`
…for-initializer Add documentation for `InitializerDeclSyntax` and all its children
Address default parameter regressions and add tests for `ForInStmtSyntax`
…ation Validate token choices in CI
…escription Improve debug description of syntax nodes
…-validation Update RawSyntaxValidationFile.swift
Minor updates to README
Don't guard assertions behind `#if DEBUG`
Rename children that refer to a `MemberDeclBlock` from `members` to `memberBlock`
…ion-fixes Fix parser failures found by source alteration in test cases
…ting Add some structure to Package.swift
…name-in-debug-description Include property names in debug description
Re-generate code-generated files
Enable a mode in the parser in which it inspects alternative token choices to mutate test cases
…ntaxparser Remove SwiftSyntaxParser module
DougGregor
approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Merged
DougGregor
approved these changes
Apr 19, 2023
2 similar comments
DougGregor
approved these changes
Apr 20, 2023
Cherry-picking caused a few codegen’d files to be out-of-date. Re-generate them now.
1300350
to
8d68708
Compare
swiftlang/swift#65239 @swift-ci Please test windows |
When you get a chance could you please tag a new Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following PRs to
release/5.9
:Trivia
cannot represent invalid UTF-8 #1490@_spi(...)
attributes. #1514#️⃣
in string literals #1520else
#1518InitializerDeclSyntax
and all its children #1527ForInStmtSyntax
#1517SwiftSyntaxBuilder
where paramters had incorrect default values, risk 2/5#if DEBUG
#1526MemberDeclBlock
frommembers
tomemberBlock
#1524