Fix parser failures found by source alteration in test cases #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
kimdv
reviewed
Apr 14, 2023
| } | ||
| """, | ||
| diagnostics: [ | ||
| DiagnosticSpec(locationMarker: "1️⃣", message: "unexpected code '==' in 'if' statement") |
There was a problem hiding this comment.
Maybe we should add a fixit if we start to require it in #1467
Same for fixedSource below
kimdv
approved these changes
Apr 14, 2023
These parser failures were found by swiftlang#1340. - There was one round-trip failure introduced by swiftlang#1464 - A few cases were just consume tokens as the wrong child - The list of expected token kinds of `DeclModifierSynax` didn’t contain one modifier that was actually parsed
ahoppen
force-pushed
the
ahoppen/source-alteration-fixes
branch
from
b0b0586 to
1f95a65
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 14, 2023
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…ion-fixes Fix parser failures found by source alteration in test cases
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…ion-fixes Fix parser failures found by source alteration in test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parser failures were found by #1340.
DeclModifierSynaxdidn’t contain one modifier that was actually parsed