Fix escape handling for emoji #️⃣ in string literals
#1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters in string literals
ahoppen
approved these changes
Apr 12, 2023
|
@swift-ci Please test |
|
Thanks for contributing to Swift @kishikawakatsumi! |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…l-escape Fix escape handling for emoji `#️⃣` in string literals
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Apr 18, 2023
…l-escape Fix escape handling for emoji `#️⃣` in string literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the escape handling when counting the number of
#characters in string literals. Previously, the code didn't consider the emoji#️⃣presence. This resulted in incorrect escape counts.For example, the string literal generated from the string
foo "#️⃣"barwould be##"foo "#️⃣"bar "##, but the current implementation generates#"foo "#️⃣"bar "#. This literal will result in a compile error because the escape is incomplete.