Split DeclEffectSpecifiers into AccessorEffectSpecifiers and FunctionEffectSpecifiers

[StevenWong12]

Part of #1373

[ahoppen]

Conceptually this boils down to a similar problem that I think we discussed in one of your other PRs: As long as we can’t represent that the effect specifier of an accessor cannot be reasync or rethrows, then no client (and “client” here includes later stages of the compiler) can assume that asyncSpecifier of an AccessorDecl cannot be reasync and thus needs to diagnose it themselves.

What needs to be done here is that we need to split DeclEffectSpecifiers into two different nodes: AccessorEffectSpecifiers and FunctionEffectSpecifiers where FunctionEffectSpecifiers does not allow rethrows and reasync. For this you need to modify the declaration of DeclEffectSpecifiers in CodeGeneration and run generate-swiftsyntax to regenerate the code. Do you think you could try that?

[StevenWong12]

Thanks for your comments! I think I only considered SwiftParserDiagnostics as the client of the parser, which makes the changes in my PRs not friendly to other clients. I think your suggestions make sense and I will make a try to modify my PRs.

[StevenWong12]

AccessorEffectSpecifiers and FunctionEffectSpecifiers where FunctionEffectSpecifiers does not allow rethrows and reasync.

Just want to make sure if there is a typo and it should be

where AccessorEffectSpecifiers does not allow rethrows and reasync

[ahoppen]

Yes, that was a typo indeed. Good catch

[StevenWong12]

I have took AccessorEffectSpecifiers apart from DeclEffectSpecifiers and renamed DeclEffectSpecifiers to FunctionEffectSpecifiers. It seems that this split also solves the TODOs in EffectfulPropertiesTests.swift without many add-ons.😀

[ahoppen]

Thanks. This looks good. I just think you have a lingering TODO comment in your codebase.

[StevenWong12]

Oh, I forgot to delete that. I've removed it and squashed my changes into a single commit.

[kimdv]

@swift-ci please test

[ahoppen]

@swift-ci Please test Windows