Skip to content

Add whitespace before else #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add whitespace before else #1518

merged 1 commit into from
Apr 12, 2023

Conversation

stevapple
Copy link
Contributor

No description provided.

@stevapple stevapple requested a review from ahoppen as a code owner April 12, 2023 06:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is those changes part of fixing the leading whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not. They may come from missing regeneration from a prior PR, or maybe caused by rebasing PRs on top of main.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was part of this PR: #1482
More specific this commit: 0e21bb7

But I see that some of the code is correctly generated in that PR 🫣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe caused by missing regeneration after rebase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think #1455 and #1482 raced here and the code for the new nodes wasn’t properly generated. My bad.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@ahoppen
Copy link
Member

ahoppen commented Apr 12, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge April 12, 2023 19:53
@ahoppen ahoppen merged commit 2ee92df into swiftlang:main Apr 12, 2023
@stevapple stevapple deleted the else-spacing branch April 13, 2023 18:05
ahoppen added a commit to ahoppen/swift-syntax that referenced this pull request Apr 18, 2023
ahoppen added a commit to ahoppen/swift-syntax that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants