Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Export TS Typings #3169

Closed
juliemr opened this issue Apr 26, 2016 · 7 comments
Closed

Export TS Typings #3169

juliemr opened this issue Apr 26, 2016 · 7 comments
Assignees

Comments

@juliemr
Copy link
Member

juliemr commented Apr 26, 2016

Now that Protractor is written in TS, we should consolidate and export typings via npm - see http://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html

@juliemr juliemr added this to the 3.4.0 milestone Apr 26, 2016
@Meligy
Copy link

Meligy commented May 9, 2016

Hello,
I've been a bit curious about this one, trying to figure out what it takes, maybe taking it for a spin.

Is that a matter of just adding this line to the packages.json file?

{
    ...
    "typings": "./lib/globals.d.ts"
    ...
}

Is there anything special with being globals or so?

Thanks a lot :)

@cnishina
Copy link
Contributor

cnishina commented May 9, 2016

I'm currently working on this... this will be broken down into several steps:

  • Move protractor.ts to browser.ts to clean up the namespaces that are exported
    • Fix selenium webdriver api's that have changed
    • Fix *.prototype in the code base
  • Create a protractor.d.ts file. Add a build rule to concat the *.d.ts file under the protractor namespace
  • Create an example that uses the protractor.d.ts file and look for issues on typings that are missing
  • Fix definitely typed selenium webdriver to remove the webdriver namespace from global.d.ts

@cnishina
Copy link
Contributor

Adding PRs that got us here: #2902, #2919, #2948, #2965, #3114, #3138, #3141, #3142, #3143, #3148, #3149, #3151, #3152, #3153, #3156, #3214, #3271, #3279, #3281, #3288, #3307

@cnishina
Copy link
Contributor

@Meligy Added typings to package.json (pr #3298)

package.json:

{
  ...
  "typings": "built/index.d.ts",
  ...
}

@hawkerm
Copy link

hawkerm commented Jul 9, 2016

Are there any examples yet of what a TS version of the config file and a test suite look like?

@igniteram
Copy link
Contributor

@heathkit heathkit modified the milestone: 4.0.0 Jul 11, 2016
@juliemr
Copy link
Member Author

juliemr commented Jul 14, 2016

Done!

@juliemr juliemr closed this as completed Jul 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants