This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(typescript): convert cli.js to cli.ts #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .alias('invert-grep', 'jasmineNodeOpts.invertGrep') | ||
| .alias('explorer', 'elementExplorer') | ||
| .string('capabilities.tunnel-identifier') | ||
| .check(function(arg: ProtractorArgs) { |
There was a problem hiding this comment.
I don't think this type is right - this is the leftover args, which is just an array of strings.
There was a problem hiding this comment.
It definitely isn't an array of strings. I didn't change the if statement on the line below. Maybe it's just {_: string[]} though
There was a problem hiding this comment.
My bad, I missed that. Yes, you're right. But if we're removing the type below, doesn't really matter.
| } | ||
|
|
||
| // Run the launcher | ||
| import * as launcher from './launcher'; |
There was a problem hiding this comment.
Maybe we should move the import to the top of the file.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.