This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(typescript): fix gulp tsc to log to console
#2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,13 @@ gulp.task('typings', function(done) { | |||
| }); | |||
|
|
|||
| gulp.task('tsc', function(done) { | |||
| runSpawn(done, 'node_modules/typescript/bin/tsc'); | |||
| var tsc = spawn('node_modules/typescript/bin/tsc'); | |||
There was a problem hiding this comment.
Hmmm, there must be a way to do this with stdio options. Gulp must be doing something funny to make inherit fail. Can we try {stdio: [process.stdin, process.stdout, process.stderr]}?
There was a problem hiding this comment.
Fixed. spawn(task, opt_arg, {stdio: 'inherit'}); required that opt_arg to be defined as an array.
|
LGTM! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child_process.spawn with
{stdio: inherit}was not printing to console.