chore(typings): rename protractor to browser and add a protractor namespace #3214
Conversation
cnishina
changed the title
|
We spoke briefly, but let's split the change to |
cnishina
changed the title
cnishina
force-pushed
the
wip_d_ts
branch
4 times, most recently
from
f28af63 to
a7c2432
Compare
| @@ -184,7 +185,7 @@ export class Protractor { | |||
| * | |||
| * @type {Plugins} Object containing plugin funtions from config. | |||
| */ | |||
| private plugins_: Plugins; | |||
| plugins_: Plugins; | |||
There was a problem hiding this comment.
Why are these no longer private?
There was a problem hiding this comment.
They were marked as private; however, lib/browser.ts makes a call to a private variable. This is the same issue for all the private variables in browser. They probably should be using a Get method.
There was a problem hiding this comment.
Maybe double check with Julie, but if they're not actually private then we should just drop the underscore at the end and remove the @Private annotations in the jsdoc as well.
There was a problem hiding this comment.
Hm yeah, these were fake private. We don't really want them as part of our documented API really, but the runner needs to access them. I'm fine making them public for now.
…espace * added wrapDriver method from the browser.ts and ExpectedConditions to the protractor namespace * imported selenium webdriver ActionSequence, Key, promise, Command, and CommandName to the protractor namespace
rename protractor to browser and add a protractor namespace