This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(types): add function types to element and locators #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cnishina
commented
Jun 17, 2016
cnishina
commented
- add 'gulp types' to output index.d.ts
- some clean up for functions to use fat arrow
- clang clean up
| contents += ' export = protractor\n'; | ||
| contents += '}\n'; | ||
|
|
||
| // remove files with d.ts |
There was a problem hiding this comment.
Why this step? Do they interfere if left in?
There was a problem hiding this comment.
I thought this would be cleaner to have one d.ts file instead of many when we publish to npm
|
Main concern is the fat-arrowing of the module that shouldn't be ES6ey. Other stuff looks reasonable. |
cnishina
force-pushed
the
pr_typings_element2
branch
2 times, most recently
from
f8fb089 to
110992e
Compare
| @@ -65,3 +68,42 @@ gulp.task('pretest', function(done) { | |||
| }); | |||
|
|
|||
| gulp.task('default',['prepublish']); | |||
|
|
|||
| gulp.task('types', ['tsc'], function(done) { | |||
There was a problem hiding this comment.
This task should be added to the sequence for 'prepublish' now.
There was a problem hiding this comment.
Adding the task to prepublish.
|
Looks good after Travis finishes (I re-ran it after a sauce connect flake) and one more comment on the gulpfile. |
- add 'gulp types' to output index.d.ts - some clean up for functions to use fat arrow - clang clean up
cnishina
force-pushed
the
pr_typings_element2
branch
from
110992e to
5c2c1b3
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.