This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(typescript): runner and launcher converted to typescript #3149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,22 @@ | |||
| // This will clash with the node 'global' namespace... | |||
There was a problem hiding this comment.
Does this comment need resolving?
There was a problem hiding this comment.
Note - if it doesn't require action, it should be a bit more verbose, because I'm not sure what it's trying to tell me.
There was a problem hiding this comment.
This does not require any immediate action but the tsc command will complain about global namespace being declared twice.
| * and save results into a JSON file. | ||
| */ | ||
| class TaskResults { | ||
| results_: any[] = []; |
There was a problem hiding this comment.
Maybe for a follow-up CL, but it might make sense to introduce a class type for results.
cnishina
force-pushed
the
pr_TSrunnerLauncher
branch
from
c514805 to
7dba2f9
Compare
| .done(); | ||
| }; | ||
|
|
||
| exports.init = init; |
There was a problem hiding this comment.
can we do export var init instead?
cnishina
force-pushed
the
pr_TSrunnerLauncher
branch
from
7dba2f9 to
0b00b5e
Compare
cnishina
force-pushed
the
pr_TSrunnerLauncher
branch
from
0b00b5e to
f941c25
Compare
|
LGTM |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.