Skip to content

Translate SQL features #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Translate SQL features #2537

merged 5 commits into from
Feb 4, 2022

Conversation

patiencedaur
Copy link
Contributor

@patiencedaur patiencedaur commented Jan 10, 2022

@patiencedaur patiencedaur added the translate Localization tasks label Jan 10, 2022
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 10, 2022 14:39 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 10, 2022 14:39 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 10, 2022 14:54 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 10, 2022 14:54 Inactive
@patiencedaur patiencedaur mentioned this pull request Jan 11, 2022
6 tasks
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 17, 2022 05:29 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 17, 2022 05:29 Inactive
@patiencedaur patiencedaur force-pushed the translate-sql-features branch from cf06e4e to 9b92a1b Compare January 17, 2022 06:04
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 17, 2022 06:05 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 17, 2022 06:06 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 17, 2022 07:01 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 17, 2022 07:02 Inactive

Total number of items marked "Fail": 67

Total number of items marked "Okay": 79
Copy link
Contributor

@NickVolynkin NickVolynkin Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a trailing newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a trailing newline, its number is 1045.

@igorkozloff igorkozloff self-assigned this Jan 20, 2022
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 20, 2022 10:54 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 20, 2022 10:55 Inactive
@alexandra-mara alexandra-mara self-requested a review January 20, 2022 14:38
@patiencedaur patiencedaur force-pushed the translate-sql-features branch from e07ad36 to 997fbe4 Compare January 27, 2022 10:37
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 27, 2022 10:38 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 27, 2022 10:38 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 27, 2022 10:41 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features January 27, 2022 10:41 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 27, 2022 10:41 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features January 27, 2022 10:42 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features February 3, 2022 09:20 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features February 3, 2022 09:20 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features February 3, 2022 09:45 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features February 3, 2022 09:45 Inactive
Copy link
Contributor

@alexandra-mara alexandra-mara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pgulutzan, @patiencedaur
I made the changes we've discussed above, and I believe this PR is ready to merge

@github-actions github-actions bot temporarily deployed to translation-translate-sql-features February 3, 2022 11:40 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features February 3, 2022 11:40 Inactive
@patiencedaur patiencedaur force-pushed the translate-sql-features branch from 538f73d to 751b017 Compare February 3, 2022 13:58
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features February 3, 2022 13:59 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features February 3, 2022 14:00 Inactive
@github-actions github-actions bot temporarily deployed to translation-translate-sql-features February 3, 2022 16:13 Inactive
@github-actions github-actions bot temporarily deployed to branch-translate-sql-features February 3, 2022 16:14 Inactive
Copy link
Contributor

@pgulutzan pgulutzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm only marked as reviewer because of my comment, I only looked for the changes that we discussed.
I didn't see the change to E153 but see it is going to be done for issue #2659, and it will be marked Fail. So I initially thought that the count at the end, Total number of items marked “Fail”: 67, would need to be changed to 68. But now I counted the number of times that I see "Fail." or "Fail," not counting F021, it seems it would be 65. But I'm not good at counting.
So I will say that it looks good to me.

@alexandra-mara
Copy link
Contributor

alexandra-mara commented Feb 4, 2022

@pgulutzan I've updated E153 with the example you provided via patch that was merged into this branch, you should be able to see it here 751b017
Yes, of course we have to recount test results, I haven't thought of that. I actually searched through this page for "Fail" occurrences and there were 55, excluding those not from the table and F021. And 80 "Okay"s. I was checking our current test deployment with these updates, it is not live yet

@patiencedaur patiencedaur merged commit fe18c83 into latest Feb 4, 2022
@patiencedaur patiencedaur deleted the translate-sql-features branch February 4, 2022 09:04
@pgulutzan
Copy link
Contributor

@alexandra-mara: the number 55 surprised me, and now I have realized: all the privilege features are gone. This isn't right, because the list is supposed to be the same as the list in the standard. I suggest that I can put them back as part of the SQL changes for issue #2523. Also I might try changing the "widths:" to see whether it looks better if there is more space in the Example column.

@alexandra-mara
Copy link
Contributor

@pgulutzan, I'm sorry I missed your message, I was away for a week. Yeah, surely we need to add privilege features, as part of #2523, or we can create a new issue

@pgulutzan
Copy link
Contributor

@alexandra-mara: in my last commit for issue #2523 ba284f0 I copied your version of sql-features.rst and added the privilege features and removed a reference to "we" due to another change in the style guide. If I remember correctly, I didn't make other significant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translate Localization tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants