-
Notifications
You must be signed in to change notification settings - Fork 43
Translate SQL features #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate SQL features #2537
Conversation
cf06e4e
to
9b92a1b
Compare
|
||
Total number of items marked "Fail": 67 | ||
|
||
Total number of items marked "Okay": 79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a trailing newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a trailing newline, its number is 1045.
e07ad36
to
997fbe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pgulutzan, @patiencedaur
I made the changes we've discussed above, and I believe this PR is ready to merge
538f73d
to
751b017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm only marked as reviewer because of my comment, I only looked for the changes that we discussed.
I didn't see the change to E153 but see it is going to be done for issue #2659, and it will be marked Fail. So I initially thought that the count at the end, Total number of items marked “Fail”: 67, would need to be changed to 68. But now I counted the number of times that I see "Fail." or "Fail," not counting F021, it seems it would be 65. But I'm not good at counting.
So I will say that it looks good to me.
@pgulutzan I've updated E153 with the example you provided via patch that was merged into this branch, you should be able to see it here 751b017 |
@alexandra-mara: the number 55 surprised me, and now I have realized: all the privilege features are gone. This isn't right, because the list is supposed to be the same as the list in the standard. I suggest that I can put them back as part of the SQL changes for issue #2523. Also I might try changing the "widths:" to see whether it looks better if there is more space in the Example column. |
@pgulutzan, I'm sorry I missed your message, I was away for a week. Yeah, surely we need to add privilege features, as part of #2523, or we can create a new issue |
@alexandra-mara: in my last commit for issue #2523 ba284f0 I copied your version of sql-features.rst and added the privilege features and removed a reference to "we" due to another change in the style guide. If I remember correctly, I didn't make other significant changes. |
Part of #2496
Page: https://www.tarantool.io/ru/doc/latest/reference/reference_sql/sql-features/
Crowdin: https://crowdin.com/translate/tarantool-docs/84117/en-ru?filter=basic&value=2
Deployment: https://develop.tarantool.io/ru/doc/translate-sql-features/reference/reference_sql/sql-features/
Words: 2466
Refactor the table of SQL features to make it maintainable and translatable.