Skip to content

[8pt] New SQL data types and function changes #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pgulutzan opened this issue Dec 22, 2021 · 6 comments
Closed

[8pt] New SQL data types and function changes #2516

pgulutzan opened this issue Dec 22, 2021 · 6 comments
Assignees
Labels
reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality sql [location] SQL manual

Comments

@pgulutzan
Copy link
Contributor

The new data types in SQL -- MAP, ARRAY, ANY -- should be done together because they affect the same charts and subsections of the SQL Reference. Also there might be an effect on SQL functions so the tentative plan is to work on those at the same time if all the changes are in the same .rst file.
Thus fixing this issue may be fixing:
Issue #2406 Literals for INTEGER, DECIMAL and DOUBLE
Issue #2439 SUBSTR() function
Issue #2440 Field type ANY in SQL
Issue #2455 Default types of SQL built-in functions
Issue #2461 Field type ARRAY in SQL
Issue #2462 Field type MAP in SQL
Issue #2475 Syntax for ARRAY in SQL

@pgulutzan pgulutzan self-assigned this Dec 22, 2021
@pgulutzan pgulutzan added reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality sql [location] SQL manual labels Dec 22, 2021
@patiencedaur patiencedaur changed the title New SQL data types and function changes [8pt] New SQL data types and function changes Jan 10, 2022
@patiencedaur
Copy link
Contributor

Dear Peter @pgulutzan,

I am now the Tarantool documentation team lead instead of @NickVolynkin.

Once you're finished working on an issue, please tag me in a comment to the PR so I know that the task is ready. Then we can review it and pass it to the translation team.

It's best if you do it for smaller chunks of work rather than large ones. For example, you described this issue as an epic overarching several other issues. In this case, tag me when you're finished with each smaller issue, not with the whole epic. This will simplify and accelerate our work.

Thank you!

P. S. We're going to update our style guide, making it more detailed. Just keeping you informed. I'll send you a link once it's finished. Here's the work in progress if you're interested: #2539.

@pgulutzan
Copy link
Contributor Author

@patiencedaur: Hi, and congratulations.

@ImeevMA has also commented and has said he intends to review, after
making some more changes. #2523 (comment)

I will add you to the CC list in weekly reports and remove Nick Volynkin.

Do you want me to add you to reviewer list as well as tag you in a comment?

I hope you can see that the close relationship between data type issues means
that they affect the same places in the same small set of files.
For example, the railroad diagrams (which have nothing to do with translation)
mention both MAP and ARRAY, and take the first change in sql_user_guide.rst:
changing
"There are five kinds of literals: BOOLEAN INTEGER DOUBLE STRING VARBINARY."
to
"There are eight kinds of literals: BOOLEAN INTEGER DOUBLE DECIMAL STRING VARBINARY ARRAY MAP."
If we had tried to split into smaller items, that would mean we'd be revising
the sentence once to add DECIMAL, revising the sentence a second time to add
ARRAY, and revising the sentence a third time to add MAP. That would have been the opposite of accelerating, wouldn't it?

I know about the style guide changes, thanks.

@patiencedaur
Copy link
Contributor

@pgulutzan
Yes, please add me to the reviewer list. Here is my work email, which you can CC the reports to: [email protected].

I understand that this epic is about making small changes to many documents. So you're right---it would be best if you notify when the whole thing is done.

How do you usually get the next assignment to work on---should I just assign issues to you so you pick them up?

@pgulutzan
Copy link
Contributor Author

pgulutzan commented Jan 14, 2022

@patiencedaur: Thanks for understanding. You've probably noticed that I used to be involved with all documentation (because K. Osipov hired me first), but nowadays I only get a few assignments related to internals or (especially) to SQL. Sometimes I self-assign what looks interesting, and always I look for flaws; you can check with the developers that I've bothered recently (e.g. M. Imeev, M. Siomkin, T. Safin, A. Turenko) and they can tell you whether they have any problems with this. And yes you can assign issues to me whenever you wish.

@patiencedaur
Copy link
Contributor

Thank you, Peter. We will definitely have something about SQL to document quite soon.

Here are the style guide updates, as promised:
https://www.tarantool.io/en/doc/latest/contributing/docs/style/

pgulutzan added a commit that referenced this issue Jan 31, 2022
pgulutzan added a commit that referenced this issue Feb 1, 2022
pgulutzan added a commit that referenced this issue Feb 7, 2022
…imported recently-changed sql-features.rst and made small adjustments
@patiencedaur
Copy link
Contributor

Related issue: #2797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reference [location] Tarantool manual, Reference part server [area] Task relates to Tarantool's server (core) functionality sql [location] SQL manual
Projects
None yet
Development

No branches or pull requests

2 participants