Skip to content

Commit e574799

Browse files
pgulutzanpgulutzan
committed
Fixes gh-2516 New SQL data types and function changes, third commit, removing WE due to style guide
1 parent 4abdf3f commit e574799

File tree

6 files changed

+91
-91
lines changed

6 files changed

+91
-91
lines changed

‎doc/reference/reference_sql/sql-features.rst

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
SQL features
55
--------------------------------------------------------------------------------
66

7-
In this section we will go through SQL:2016's "Feature taxonomy and definition
7+
This section compares Tarantool's features with SQL:2016's "Feature taxonomy and definition
88
for mandatory features".
99

10-
For each feature in that list, we will come up with a simple example SQL
10+
For each feature in that list, there will be a simple example SQL
1111
statement.
12-
If Tarantool appears to handle the example, we will mark it "Okay",
13-
else we will mark it "Fail".
14-
Since this is rough and arbitrary, we believe that tests which are unfairly
12+
If Tarantool appears to handle the example, it will be marked "Okay",
13+
else it will be marked "Fail".
14+
Since this is rough and arbitrary, the hope is that tests which are unfairly
1515
marked "Okay" will probably be balanced by tests which are unfairly marked "Fail".
1616

1717
.. container:: table
@@ -34,7 +34,7 @@ marked "Okay" will probably be balanced by tests which are unfairly marked "Fail
3434
| | | | these types, but will restrict it to 'float32' and |
3535
| | | | 'float64' in 2.2. The format change requires data |
3636
| | | | migration and cannot be done automatically, because in |
37-
| | | | 2.1 we have no information to distinguish 'number' |
37+
| | | | 2.1 there is no information to distinguish 'number' |
3838
| | | | columns (created from Lua) from FLOAT/DOUBLE/REAL ones |
3939
| | | | (created from SQL). |
4040
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
@@ -83,7 +83,7 @@ marked "Okay" will probably be balanced by tests which are unfairly marked "Fail
8383
| | | | :ref:`POSITION <sql_function_position>` function |
8484
| | | | requires '``,``' rather than '``IN``'. |
8585
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
86-
| E021-12 | Character comparison | ``SELECT * FROM t WHERE s1 > 'a';`` | Okay. We should note here that comparisons use a binary |
86+
| E021-12 | Character comparison | ``SELECT * FROM t WHERE s1 > 'a';`` | Okay. For STRING comparisons Tarantool uses a binary |
8787
| | | | collation by default, but it is easy to use a |
8888
| | | | :ref:`COLLATE clause <sql_collate_clause>`. |
8989
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
@@ -263,8 +263,8 @@ marked "Okay" will probably be balanced by tests which are unfairly marked "Fail
263263
| E141-07 | Column defaults | ``CREATE TABLE t13 (s1 INT PRIMARY KEY, s2 INT | Okay. |
264264
| | | DEFAULT -1);`` | |
265265
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
266-
| E141-08 | NOT NULL inferred on primary key | ``CREATE TABLE t14 (s1 INT PRIMARY KEY);`` | Okay. We are unable to insert NULL although we don't |
267-
| | | | explicitly say the column is NOT NULL. |
266+
| E141-08 | NOT NULL inferred on primary key | ``CREATE TABLE t14 (s1 INT PRIMARY KEY);`` | Okay. It is not possible to insert NULL although |
267+
| | | | there is no explicit NOT NULL clause. |
268268
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
269269
| E141-10 | Names in a foreign key can be specified in | ``CREATE TABLE t15 (s1 INT, s2 INT, PRIMARY KEY | Okay. |
270270
| | any order | (s1,s2));`` | |
@@ -299,8 +299,8 @@ marked "Okay" will probably be balanced by tests which are unfairly marked "Fail
299299
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
300300
| F031 | Basic schema manipulation |
301301
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
302-
| F031-01 | CREATE TABLE statement to create persistent | ``CREATE TABLE t20 (t20_1 INT NOT NULL);`` | Fail. We always have to say PRIMARY KEY (we only |
303-
| | base tables | | count this flaw once). |
302+
| F031-01 | CREATE TABLE statement to create persistent | ``CREATE TABLE t20 (t20_1 INT NOT NULL);`` | Fail. Tarantool always requires a PRIMARY KEY (this |
303+
| | base tables | | flaw will only be counted once). |
304304
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+
305305
| F031-02 | CREATE VIEW statement | ``CREATE VIEW t21 AS SELECT * FROM t20;`` | :ref:`Okay <sql_create_view>`. |
306306
+------------+-----------------------------------------------+----------------------------------------------------------+---------------------------------------------------------+

‎doc/reference/reference_sql/sql.rst

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,27 @@ provider, a dozens-of-professionals staff of programmers and support people, a c
2222
in open-source BSD licensing, and hundreds of corporations / government bodies using Tarantool products in production already.
2323

2424
The status of Tarantool's SQL feature is "release". So, it is working now and you can verify
25-
that by downloading it and trying all the features, which we will explain in the rest of this document.
25+
that by downloading it and trying all the features, which will be explained in the rest of this document.
2626
There is also a :ref:`tutorial <sql_tutorial>`.
2727

2828
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2929
Differences from other products
3030
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3131

3232
Differences from other SQL products:
33-
We believe that Tarantool's SQL conforms to the majority of the listed
34-
mandatory requirements of the core SQL:2016 standard, and we
35-
enumerate the specific conformance statements in the feature list
33+
The Tarantool design requirement is that Tarantool's SQL conforms to the majority of the listed
34+
mandatory requirements of the core SQL:2016 standard, and this
35+
will be shown in the specific conformance statements in the feature list
3636
in a section about :ref:`"compliance with the official SQL standard" <sql>`.
37-
We believe that the deviations which most people will find notable are:
37+
Possibly the deviations which most people will find notable are:
3838
type checking is less strict,
3939
and some data definition options must be done with NoSQL syntax.
4040

4141
Differences from other NoSQL products:
42-
We have examined attempts by others to paste relatively smaller
43-
subsets of SQL onto NoSQL products, and concluded that Tarantool's
42+
By examining attempts by others to paste relatively smaller
43+
subsets of SQL onto NoSQL products, it should be possible to conclude that Tarantool's
4444
SQL has demonstrably more features and capabilities.
45-
The reason is that we started with a complete code base of
45+
The reason is that the Tarantool developers started with a complete code base of
4646
a working SQL DBMS and made it work with Tarantool-NoSQL underneath,
4747
rather than starting with a NoSQL DBMS and adding syntax to it.
4848

0 commit comments

Comments
 (0)