-
-
Notifications
You must be signed in to change notification settings - Fork 60
Add setup.py #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup.py #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tiran
Can you also update cherry_picker/readme.rst?
I think the section about Setup Info should be updated to have people run venv/bin/pip install .
And then under alternate usage
at the top, people can use python cherry_picker ...
from an existing cpython directory.
``venv/bin/pip install .`` installs all dependencies and venv/bin/cherry_picker script. Signed-off-by: Christian Heimes <[email protected]>
@Mariatta I have amended the commit and updated the readme as request. I also replaced |
Thanks @tiran :) @brettcannon or @ncoghlan: Could one of you review this too please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although you may want to use the mailing list's email address rather than your personal one.
license='Apache', | ||
url='https://github.com/python/core-workflow', | ||
author='Mariatta Wijaya', | ||
author_email='[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to put [email protected]
as your address here, so folks know to contact the list with any questions, rather than contacting you directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added @Mariatta 's mail address. We may want to keep it and add maintainer / maintainer_email for contact. After all Marietta wrote the script and deserves credits. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😸 Well I've prepared a canned response already "Please file an issue at python/core-workflow"
I'll add the following:
"maintainer": "Python Core Developers",
"maintainer_email": "[email protected]",
Question: is version
metadata not needed? The doc seems to indicate that it's required.
Thanks @tiran |
venv/bin/pip install .
installs all dependencies andvenv/bin/cherry_picker script.
Signed-off-by: Christian Heimes [email protected]
Closes #50
Closes #64
Closes #89