Skip to content

Add setup.py #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2017
Merged

Add setup.py #99

merged 4 commits into from
May 31, 2017

Conversation

tiran
Copy link
Member

@tiran tiran commented May 24, 2017

venv/bin/pip install . installs all dependencies and
venv/bin/cherry_picker script.

Signed-off-by: Christian Heimes [email protected]

Closes #50
Closes #64
Closes #89

@Mariatta
Copy link
Member

Thanks @tiran I believe this will close #64 So I edited the description.

Will actually review later this evening :)

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tiran

Can you also update cherry_picker/readme.rst?

I think the section about Setup Info should be updated to have people run venv/bin/pip install .

And then under alternate usage at the top, people can use python cherry_picker ... from an existing cpython directory.

``venv/bin/pip install .`` installs all dependencies and
venv/bin/cherry_picker script.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Copy link
Member Author

tiran commented May 30, 2017

@Mariatta I have amended the commit and updated the readme as request. I also replaced (venv) $ python -m cherry_picker with just (venv) $ cherry_picker.

@Mariatta Mariatta dismissed their stale review May 31, 2017 04:35

Requested changes have been made

@Mariatta
Copy link
Member

Thanks @tiran :)
I tested this PR, and made some adjustment to the documentation.

@brettcannon or @ncoghlan: Could one of you review this too please?
I'm trying to simplify the setup process, and making the assumption that most people will prefer to cherry_pick from their existing cloned CPython directory instead of cloning it again. So I updated that part of the readme. Thanks.

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although you may want to use the mailing list's email address rather than your personal one.

license='Apache',
url='https://github.com/python/core-workflow',
author='Mariatta Wijaya',
author_email='[email protected]',
Copy link
Contributor

@ncoghlan ncoghlan May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to put [email protected] as your address here, so folks know to contact the list with any questions, rather than contacting you directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @Mariatta 's mail address. We may want to keep it and add maintainer / maintainer_email for contact. After all Marietta wrote the script and deserves credits. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😸 Well I've prepared a canned response already "Please file an issue at python/core-workflow"

I'll add the following:

"maintainer": "Python Core Developers",
"maintainer_email": "[email protected]",

Question: is version metadata not needed? The doc seems to indicate that it's required.

@Mariatta Mariatta merged commit 4e04a45 into python:master May 31, 2017
@Mariatta
Copy link
Member

Thanks @tiran
You closed 5 open issues with one PR! 🎉 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants