Skip to content

When cherry_picker fails, drop you off in the checkout #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue Mar 17, 2017 · 5 comments
Closed

When cherry_picker fails, drop you off in the checkout #51

brettcannon opened this issue Mar 17, 2017 · 5 comments
Assignees

Comments

@brettcannon
Copy link
Member

I just had a cherry-pick fail, but because I was running cherry_picker from its own git repo it took me a minute to realize that I couldn't find the failed branch because I had not cd cpython yet. It might work out better to automatically cd into the checkout upon failure (with an appropriate message that this was done).

@Mariatta
Copy link
Member

Sorry about that.. yeah it's definitely something that I need to address. Maybe related to #45 too

@brettcannon
Copy link
Member Author

@Mariatta Nothing to apologize for! Tool worked out great (only issue is GitHub seems to keep thinking I might want to create a PR for the 3.5 branch)!

@ncoghlan
Copy link
Contributor

If we did decide to do this (and I think it's reasonable for the interactive case), it would be helpful if it printed two things before exiting:

  • a command to finish just the "commit-and-push-and-open-web-browser" steps for the current target branch
  • a command to run the cherry-pick again for any not yet processed branches

@Mariatta
Copy link
Member

Hmm.. I couldn't figure out how to actually cd to the cpython directory and let it persist there after cherry_picker.py ended 😅 So instead I'm printing out the message that you need to cd cpython first..

@Mariatta Mariatta self-assigned this Mar 22, 2017
@Mariatta
Copy link
Member

Once #99 is merged, this is not needed anymore since the people will be cherry-picking from cpython directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants