Skip to content

Replace Iterable by List #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks done
php-coder opened this issue Jan 14, 2016 · 0 comments
Closed
9 tasks done

Replace Iterable by List #321

php-coder opened this issue Jan 14, 2016 · 0 comments
Assignees
@php-coder
Labels
refactoring trivial
Milestone
0.4

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 14, 2016 •
edited
Loading

We should replace Iterable<X> by List<X>:

  • CategoryService.findAllAsSelectEntities() (will be removed in Remove id from category URL #206)
  • CategoryService.findAllAsLinkEntities()
  • CollectionService.findRecentlyCreated()
  • CountryService.findAllAsLinkEntities()
  • SeriesService.findByCategoryId()
  • SeriesService.findByCountryId()
  • SeriesService.findByCollectionId()
  • SeriesService.findRecentlyAdded()
  • SeriesService.findAllForSitemap()
@php-coder php-coder added this to the next milestone Jul 29, 2016
php-coder added a commit that referenced this issue Aug 1, 2016
@php-coder
CollectionService.findRecentlyCreated(): change return type to List.
7fd84ad 
Addressed to #321

No functional changes.
@php-coder php-coder self-assigned this Aug 1, 2016
@php-coder php-coder modified the milestones: 0.4, next Aug 1, 2016
php-coder added a commit that referenced this issue Aug 2, 2016
@php-coder
SeriesService.findByCategoryId(): change return type to List.
d6ffc01 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 2, 2016
@php-coder
SeriesService.findByCountryId(): change return type to List.
4d7da78 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 2, 2016
@php-coder
SeriesService.findByCollectionId(): change return type to List.
cd6fd8a 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 3, 2016
@php-coder
SeriesService.findRecentlyAdded(): change return type to List.
74361f4 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 3, 2016
@php-coder
SeriesService.findAllForSitemap(): change return type to List.
e72972b 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 4, 2016
@php-coder
CountryService.findAllAsLinkEntities(): change return type to List.
7eb5353 
Addressed to #321

No functional changes.
php-coder added a commit that referenced this issue Aug 4, 2016
@php-coder
CategoryService.findAllAsLinkEntities(): change return type to List.
9353f41 
Addressed to #321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
CollectionService.findRecentlyCreated(): change return type to List.
2554e64 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
SeriesService.findByCategoryId(): change return type to List.
806beea 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
SeriesService.findByCountryId(): change return type to List.
1cdb5ae 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
SeriesService.findByCollectionId(): change return type to List.
cbaebcd 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
SeriesService.findRecentlyAdded(): change return type to List.
a314326 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
SeriesService.findAllForSitemap(): change return type to List.
d236b51 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
CountryService.findAllAsLinkEntities(): change return type to List.
1046aae 
Addressed to php-coder#321

No functional changes.
cssru pushed a commit to cssru/mystamps that referenced this issue Aug 24, 2016
@php-coder @cssru
CategoryService.findAllAsLinkEntities(): change return type to List.
022c2f2 
Addressed to php-coder#321

No functional changes.
@Shkarin Shkarin mentioned this issue Aug 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder