SeriesService.findByCollectionId(): change return type to List.

Addressed to #321

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/controller/CollectionController.java

@@ -73,7 +73,7 @@ public String showInfo(
 		model.addAttribute("ownerName", owner);
 
 		String lang = LocaleUtils.getLanguageOrNull(userLocale);
-		Iterable<SeriesInfoDto> seriesOfCollection =
+		List<SeriesInfoDto> seriesOfCollection =
 			seriesService.findByCollectionId(collectionId, lang);
 		model.addAttribute("seriesOfCollection", seriesOfCollection);
 

src/main/java/ru/mystamps/web/dao/SeriesDao.java

@@ -36,7 +36,7 @@ public interface SeriesDao {
 	List<SeriesInfoDto> findByIdsAsSeriesInfo(List<Integer> seriesIds, String lang);
 	List<SeriesInfoDto> findByCategoryIdAsSeriesInfo(Integer categoryId, String lang);
 	List<SeriesInfoDto> findByCountryIdAsSeriesInfo(Integer countryId, String lang);
-	Iterable<SeriesInfoDto> findByCollectionIdAsSeriesInfo(Integer collectionId, String lang);
+	List<SeriesInfoDto> findByCollectionIdAsSeriesInfo(Integer collectionId, String lang);
 	long countAll();
 	long countAllStamps();
 	long countSeriesOfCollection(Integer collectionId);

src/main/java/ru/mystamps/web/dao/impl/JdbcSeriesDao.java

@@ -241,8 +241,7 @@ public List<SeriesInfoDto> findByCountryIdAsSeriesInfo(Integer countryId, String
 	}
 
 	@Override
-	// CheckStyle: ignore LineLength for next 1 line
-	public Iterable<SeriesInfoDto> findByCollectionIdAsSeriesInfo(Integer collectionId, String lang) {
+	public List<SeriesInfoDto> findByCollectionIdAsSeriesInfo(Integer collectionId, String lang) {
 		Map<String, Object> params = new HashMap<>();
 		params.put("collection_id", collectionId);
 		params.put("lang", lang);

src/main/java/ru/mystamps/web/service/SeriesService.java

@@ -48,7 +48,7 @@ public interface SeriesService {
 
 	List<SeriesInfoDto> findByCategoryId(Integer categoryId, String lang);
 	List<SeriesInfoDto> findByCountryId(Integer countryId, String lang);
-	Iterable<SeriesInfoDto> findByCollectionId(Integer collectionId, String lang);
+	List<SeriesInfoDto> findByCollectionId(Integer collectionId, String lang);
 	Iterable<SeriesInfoDto> findRecentlyAdded(int quantity, String lang);
 	Iterable<SitemapInfoDto> findAllForSitemap();
 }

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

@@ -329,7 +329,7 @@ public List<SeriesInfoDto> findByCountryId(Integer countryId, String lang) {
 
 	@Override
 	@Transactional(readOnly = true)
-	public Iterable<SeriesInfoDto> findByCollectionId(Integer collectionId, String lang) {
+	public List<SeriesInfoDto> findByCollectionId(Integer collectionId, String lang) {
 		Validate.isTrue(collectionId != null, "Collection id must be non null");
 
 		return seriesDao.findByCollectionIdAsSeriesInfo(collectionId, lang);