CategoryService.findAllAsLinkEntities(): change return type to List.

Addressed to #321

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/controller/CategoryController.java

@@ -121,7 +121,7 @@ public String showInfo(
 	@RequestMapping(Url.LIST_CATEGORIES_PAGE)
 	public void list(Model model, Locale userLocale) {
 		String lang = LocaleUtils.getLanguageOrNull(userLocale);
-		Iterable<LinkEntityDto> categories = categoryService.findAllAsLinkEntities(lang);
+		List<LinkEntityDto> categories = categoryService.findAllAsLinkEntities(lang);
 
 		model.addAttribute("categories", categories);
 	}

src/main/java/ru/mystamps/web/dao/CategoryDao.java

@@ -33,6 +33,6 @@ public interface CategoryDao {
 	long countAddedSince(Date date);
 	List<Object[]> getStatisticsOf(Integer collectionId, String lang);
 	Iterable<SelectEntityDto> findAllAsSelectEntities(String lang);
-	Iterable<LinkEntityDto> findAllAsLinkEntities(String lang);
+	List<LinkEntityDto> findAllAsLinkEntities(String lang);
 	LinkEntityDto findOneAsLinkEntity(Integer categoryId, String lang);
 }

src/main/java/ru/mystamps/web/dao/impl/JdbcCategoryDao.java

@@ -171,7 +171,7 @@ public Iterable<SelectEntityDto> findAllAsSelectEntities(String lang) {
 	}
 
 	@Override
-	public Iterable<LinkEntityDto> findAllAsLinkEntities(String lang) {
+	public List<LinkEntityDto> findAllAsLinkEntities(String lang) {
 		return jdbcTemplate.query(
 			findCategoriesNamesWithSlugSql,
 			Collections.singletonMap("lang", lang),

src/main/java/ru/mystamps/web/service/CategoryService.java

@@ -28,7 +28,7 @@
 public interface CategoryService {
 	UrlEntityDto add(AddCategoryDto dto, Integer userId);
 	Iterable<SelectEntityDto> findAllAsSelectEntities(String lang);
-	Iterable<LinkEntityDto> findAllAsLinkEntities(String lang);
+	List<LinkEntityDto> findAllAsLinkEntities(String lang);
 	LinkEntityDto findOneAsLinkEntity(Integer categoryId, String lang);
 	long countAll();
 	long countCategoriesOf(Integer collectionId);

src/main/java/ru/mystamps/web/service/CategoryServiceImpl.java

@@ -88,7 +88,7 @@ public Iterable<SelectEntityDto> findAllAsSelectEntities(String lang) {
 
 	@Override
 	@Transactional(readOnly = true)
-	public Iterable<LinkEntityDto> findAllAsLinkEntities(String lang) {
+	public List<LinkEntityDto> findAllAsLinkEntities(String lang) {
 		return categoryDao.findAllAsLinkEntities(lang);
 	}
 

src/test/groovy/ru/mystamps/web/service/CategoryServiceImplTest.groovy

@@ -239,7 +239,7 @@ class CategoryServiceImplTest extends Specification {
 		and:
 			categoryDao.findAllAsLinkEntities(_ as String) >> expectedCategories
 		when:
-			Iterable<LinkEntityDto> resultCategories = service.findAllAsLinkEntities('fr')
+			List<LinkEntityDto> resultCategories = service.findAllAsLinkEntities('fr')
 		then:
 			resultCategories == expectedCategories
 	}