-
Notifications
You must be signed in to change notification settings - Fork 3
Support targeting context accessor #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhiyuanliang-ms
merged 11 commits into
preview
from
zhiyuanliang/targeting-context-accessor
Mar 26, 2025
Merged
Support targeting context accessor #93
zhiyuanliang-ms
merged 11 commits into
preview
from
zhiyuanliang/targeting-context-accessor
Mar 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/feature-management/package-lock.json: Language not supported
- src/feature-management/src/filter/TargetingFilter.ts: Evaluated as low risk
juniwang
reviewed
Feb 12, 2025
juniwang
reviewed
Feb 12, 2025
juniwang
reviewed
Feb 12, 2025
Example are added in #105 |
jimmyca15
reviewed
Mar 5, 2025
jimmyca15
reviewed
Mar 5, 2025
jimmyca15
reviewed
Mar 5, 2025
…ent-JavaScript into zhiyuanliang/targeting-context-accessor
rossgrambo
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
#55
Support targeting context accessor pattern, align with other FM libraries
Usage
An example application can be found #105
If targeting context is explicitly provided within
isEnabled
orgetVariant
call, it will have the higher priority than the targeting context accessor. See the testcases and comment