Skip to content

Add an express example to demostrate ambient targeting usage #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 10, 2025
Merged

Add an express example to demostrate ambient targeting usage #105

merged 20 commits into from
Apr 10, 2025

Conversation

zhiyuanliang-ms
Copy link
Contributor

#93

@zhiyuanliang-ms zhiyuanliang-ms mentioned this pull request Feb 22, 2025
Merged
zhiyuanliang-ms
zhiyuanliang-ms commented Feb 22, 2025
View reviewed changes
zhiyuanliang-ms
zhiyuanliang-ms commented Mar 4, 2025
View reviewed changes
zhiyuanliang-ms
zhiyuanliang-ms commented Mar 4, 2025
View reviewed changes
rossgrambo
rossgrambo previously approved these changes Mar 25, 2025
View reviewed changes
Copy link

@rossgrambo rossgrambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know targetingcontextaccessor PR changes will lead to changes here- but I think this example is great and quite clear.

Base automatically changed from zhiyuanliang/targeting-context-accessor to preview March 26, 2025 02:39
@zhiyuanliang-ms zhiyuanliang-ms dismissed rossgrambo’s stale review March 26, 2025 02:39

The base branch was changed.

@zhiyuanliang-ms
Copy link
Contributor Author

@rossgrambo Could you approve this PR?

rossgrambo
rossgrambo previously approved these changes Apr 7, 2025
View reviewed changes
@zhiyuanliang-ms
Copy link
Contributor Author

@rossgrambo Could you approve this PR again?

@zhiyuanliang-ms zhiyuanliang-ms merged commit 6adbb93 into preview Apr 10, 2025
3 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/ambient-targeting-example branch April 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossgrambo rossgrambo rossgrambo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyuanliang-ms @rossgrambo