-
Notifications
You must be signed in to change notification settings - Fork 3
Support telemetry processor & initializer #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (12)
- src/feature-management-applicationinsights-browser/package.json: Language not supported
- src/feature-management-applicationinsights-node/package.json: Language not supported
- src/feature-management/package-lock.json: Language not supported
- src/feature-management/package.json: Language not supported
- src/feature-management/src/common/ITargetingContext.ts: Evaluated as low risk
- src/feature-management/src/filter/TargetingFilter.ts: Evaluated as low risk
- src/feature-management/src/index.ts: Evaluated as low risk
- src/feature-management/src/IFeatureManager.ts: Evaluated as low risk
- src/feature-management-applicationinsights-node/src/index.ts: Evaluated as low risk
- src/feature-management/src/featureManager.ts: Evaluated as low risk
- src/feature-management-applicationinsights-browser/src/index.ts: Evaluated as low risk
- src/feature-management/test/targetingFilter.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/feature-management-applicationinsights-node/src/telemetry.ts:52
- The warning message 'Targeting id is undefined.' is unclear. Consider changing it to 'TargetingContextAccessor returned undefined userId.' to provide more context.
console.warn("Targeting id is undefined.");
rossgrambo
reviewed
Mar 25, 2025
src/feature-management-applicationinsights-node/src/telemetry.ts
Outdated
Show resolved
Hide resolved
I imagine this PR needs to pull the updates from the other PR |
Base automatically changed from
zhiyuanliang/targeting-context-accessor
to
preview
March 26, 2025 02:39
…ent-JavaScript into zhiyuanliang/telemetry-processor
rossgrambo
previously approved these changes
Apr 17, 2025
src/feature-management-applicationinsights-node/src/telemetry.ts
Outdated
Show resolved
Hide resolved
CsCherrYY
previously approved these changes
Apr 18, 2025
325fbef
CsCherrYY
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
This PR is based on the targeting context accessor PR: #93
Support automatically attaching targeting id to telemetry like request, dependency which are collected automatically by app insights
Similar to the exisiting pattern
Usage
Node
Browser
Reference
Classic Application Insights v2 SDK for Node: doc
Application Insights SDK for browser: doc
POC