Introduce cask #492
Introduce cask #492
Conversation
|
This still contains the wrapper-process tests, not sure if that is intended. Also you are breaking emacs 23 compatibilty and sadly I don't see an easy way around that as you use package.el and cask and both work only from 24 upwards. I'm not one of the maintainers so you need to wait for them to comment but afaik they want to still support emacs 23 (hi debian stable users or who is still using 23 :)). |
Yes, it is intended. If the previous PR is merged (I suppose I must fix the emacs-23 package.el dependency first), we will see only the cask introduction as asked.
I suppose this package.el can help.
Yes, I wait :D emacs-23 is breaking because of an unfortunate cask limitation. @gracjan asks me to have a dedicated PR for introducing cask so I did. Note Anyway, thanks @cocreature for your interest :D Cheers, |
ardumont
force-pushed
the
introduce-cask
branch
4 times, most recently
from
f41be4d to
8d32d7d
Compare
Follow up from the discussion haskell#370 (comment) Use: - Install Cask - http://cask.readthedocs.org/en/latest/guide/installation.html ```sh curl -fsSL https://raw.githubusercontent.com/cask/cask/master/go | python ``` - Trigger tests: ``` make check ``` This will use cask only for the tests target. *Beware* emacs-23 is not supported by Cask.
|
Rebased and removed the dependencies on #491. I think that since the emacs-23 compatibility is a goal, this may not be the right approach right now (at least during the unknown period of emacs-23 compability for haskell-mode and no compatibility for Cask). Also, some new discussion on #491 made me realize there is a way to deal with external dependencies which may not be perfect (duplication of existing code). So, my 2 cents, I think you can close it :D Cheers, |
|
Yep. We will have your code waiting for times when it is really needed! Closing for now! |
As asked ardumont/haskell-mode@ec29dfb#commitcomment-10007144
Depends on #491 to explicit the problem this solves.
I suppose the original PR #372 can be closed.
Cheers,