Proposal - Add Cask to deal with test dependencies #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardumont
changed the title
ardumont
changed the title
ardumont
force-pushed
the
add-cask-to-run-tests
branch
from
77ae655 to
45358e2
Compare
ardumont
force-pushed
the
add-cask-to-run-tests
branch
2 times, most recently
from
ebb37cf to
be1f857
Compare
|
@ardumont: In case you did not see this fails with: Is there a way to fix this? |
Thanks for raising this up. If haskell-mode maintainers are interested, I will rebase to the latest code, squash, remove commits, etc.. |
Follow up from the discussion haskell#370 (comment) Use: - Install Cask - http://cask.readthedocs.org/en/latest/guide/installation.html ```sh curl -fsSL https://raw.githubusercontent.com/cask/cask/master/go | python ``` - Trigger tests: ``` make check ``` This will use cask only for the tests target. Conflicts: Makefile tests/haskell-process-tests.el
ardumont
force-pushed
the
add-cask-to-run-tests
branch
from
be1f857 to
ec29dfb
Compare
| @@ -10,6 +10,7 @@ | |||
| ;; 2003 Dave Love <[email protected]> | |||
| ;; Keywords: faces files Haskell | |||
| ;; URL: https://github.com/haskell/haskell-mode | |||
| ;; Version: 13.07 | |||
There was a problem hiding this comment.
I need a version here otherwise cask is not happy.
What should be the right one here?
|
I'm working on it :D |
Closed
|
I think we can also close this one too as this was split in 2: Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this PR, I needed to add some unit test lib (el-mock) to tests that I did not break anything.
As no dependencies seems necessary until now, I just added a temporary HACK to solve the dependency (#370 (diff)) at the time.
This comes to solve this HACK (and maybe later ease the installation of new deps).
Cask seemed a proper solution for this.
Here is a way to make Cask run the tests (and solve tests dependencies).
The only issue now seems that in the current ci-travis, the
emacs-snapshotyou use is anemacs 23.3 and Cask only supports emacs >= 24... (that's why the ci break on
emacs-snapshot)Note If you accept the previous PR, you'll see only the 2 latest commits which add Cask.
Cheers,