Add tests to haskell-process-wrapper-function

[ardumont]

As asked ardumont@ec29dfb#commitcomment-10007144

Cheers,

[cocreature]

As this is no longer related to cask, you should probably change the commit message. What is the reason for changing the gitignore? Is that no longer needed?

[ardumont]

lol.

Indeed, I focused so much on the content of the commit, I forgot the message!

For the .gitignore, I tried to keep it it was before.

[ardumont]

Rebased!

Thanks!

[ardumont]

As usual, beware the ugly hack!

Uglier because of emacs-23 compat' issue on package.

[gracjan]

@ardumont: There is a directory tests/compat that already has cl-lib.el and ert.el. Just put el-mock.el in there and you will not need to download it from anywhere.

(el-mock.el is under GPL and has license in itself, so this copy is ok license wise).

[ardumont]

Neat, way better!

Thanks for the information, will update this then.

Cheers,

On Wed, 4 Mar 2015 09:01 gracjan [email protected] wrote:

@ardumont https://github.com/ardumont: There is a directory tests/compat
that already has cl-lib.el and ert.el. Just put el-mock.el in there and
you will not need to download it from anywhere.

(el-mock.el is under GPL and has license in itself, so this copy is ok
license wise).

—
Reply to this email directly or view it on GitHub
#491 (comment).

[gracjan]

Having said that can't we get away without el-mock.el? For example this fragment:

(mocklet (((haskell-session-name "dummy-session") => "dumses1"))
    (haskell-process-compute-process-log-and-command "dummy-session" 'ghci)))

isn't it equivalent to:

(let ((haskell-session-name (lambda (x) "dumses1")))
    (haskell-process-compute-process-log-and-command "dummy-session" 'ghci)))

?

Emacs is dynamically bound (usually). This has plenty of downsides but a couple of upsides, too :)

[gracjan]

Also cl is frowned upon in favor of cl-lib.

[ardumont]

(let ((haskell-session-name (lambda (x) "dumses1")))
(haskell-process-compute-process-log-and-command "dummy-session" 'ghci)))

I'm not sure.
Also, I'm not sure that the different emacs versions does work the same way with this.

Emacs is dynamically bound (usually). This has plenty of downsides but a couple of upsides, too :)

Indeed.

Also cl is frowned upon in favor of cl-lib.

Right. I admit, I'm kind of overwhelmed with this cl thing.
I never remember which one to use :D

[gracjan]

Digging inside el-mock.el reveals that it does some advanced redefinition magic and does not use dynamic variables. It that case it makes sense to pull this dependency in.

[ardumont]

Digging inside el-mock.el reveals that it does some advanced redefinition magic and does not use dynamic variables. It that case it makes sense to pull this dependency in.

I'm at work right now.
This evening, I will rework this PR to add el-mock.el in the tests/compat/ folder
(EDIT: fix from typo contrib to tests/compat).

As a consequence, I'll also rework #492 and remove the dependency on this PR (that is by removing the common commit, this one).

Cheers,

[ardumont]

Nope, that won't work.

The tests/compat folder is for emacs version < 24.
We need el-mock for all versions (as per this PR).

What about adding another folder tests/deps (or a better name) and adding el-mock.el there.
Then updating the EFLAG entry to add this folder as dependencies?

[gracjan]

test/compat should be added as the last element to load-path so that whatever is not found in standard locations is found there.

And it should be added for all Emacs versions.

[ardumont]

Nope, that won't work.

And indeed, it does not.

What about adding another folder tests/deps (or a better name) and adding el-mock.el there.
Then updating the EFLAG entry to add this folder as dependencies?

This does :D

test/compat should be added as the last element to load-path so that whatever is not found in standard locations is found there.
And it should be added for all Emacs versions.

Are you suggesting I update the EFLAG according to this and integrate this in this PR?

[ardumont]

test/compat should be added as the last element to load-path so that whatever is not found in standard locations is found there.
And it should be added for all Emacs versions.

Are you suggesting I update the EFLAG according to this and integrate this in this PR?

It also works (at least on my emacs-24-4).

[gracjan]

@ardumont: looks very good! I'll check this out soon as time permits.

[gracjan]

I've reworked your commits for better history and merged them. Thanks!

[gracjan]

@ardumont: note that there are plenty of other functions in haskell-process that could use unit testing. You have el-mock.el in the repo, how about you write some more tests?

[ardumont]

I've reworked your commits for better history and merged them. Thanks!

Great!

@ardumont: note that there are plenty of other functions in haskell-process that could use unit testing. You have el-mock.el in the repo, how about you write some more tests?

Right. I'll see what I can do.

Cheers,

[ardumont]

I'll see what I can do.

WIP https://github.com/ardumont/haskell-mode/tree/add-tests-to-haskell-process-namespace

I'm working (slowly) on it.