-
Notifications
You must be signed in to change notification settings - Fork 137
Optimizing currently included PNGs #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xB10C Thanks for getting on this. Based on your original suggestion (thanks!) I optimized the compatibility matrix screenshots and logos for both the merged and unmerged compatibility commits. This PR finishes the job.
It looks like there are some images in /img/sponsors/ that were not changed. Were those already optimized?
add the PNGs from the currently open PRs
Can you clarify this for me?
Oh sorry, I did't know you had already optimized the PNGs in the open PRs (i.e. the ones mentioned above). Then all PNGs should be optimized.
The images in img/sponsors/ are JPEGs and not PNGs. Not sure if we can really do lossless optimization on these. But I'll have a look. |
#200 is merged. Can this be closed? |
The three JPEGs in
I think this PR should cover all PNGs. I'll mark it as ready for review. |
ACK 773cd55 . Lightly tested by looking at each modified image in my preferred image viewer (geeqie): Interestingly, both the original and modified copies of |
Thank you for the review @harding! |
Optimized with
optipng -o7
. Will rebase and add the PNGs from the currently open PRs (e.g. #179, #180, #181) once they are merged (if necessary). Happy to squash before merging this PR.refs #195