Skip to content

Compatibility data: electrum greenaddress jaxx ledger-live mycelium #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bitschmidty
Copy link
Contributor

No description provided.

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from 7907baf to 6c1ba16 Compare August 6, 2019 15:56
@jnewbery jnewbery force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from 6c1ba16 to 0764f75 Compare August 7, 2019 01:38
@jnewbery
Copy link
Contributor

jnewbery commented Aug 7, 2019

rebased

@jnewbery
Copy link
Contributor

jnewbery commented Aug 7, 2019

Added mycelium

@jnewbery jnewbery changed the title Compatibility data: electrum greenaddress jaxx ledger live Compatibility data: electrum greenaddress jaxx ledger-live mycelium Aug 7, 2019
@jnewbery
Copy link
Contributor

jnewbery commented Aug 7, 2019

@moneyball - please review for typos/formatting/etc. Let me know if you can't review this week. Thanks!

@bitschmidty
Copy link
Contributor Author

pushed commits with:

  • changes to the captions prefixes made per Launch compatibility matrix #183 (comment)
  • changes to caption wording based on Bitcoin Core wallet example
  • moved images into /rbf/ sub folder to be consistent with /segwit/ usability images (and more clear)
  • changes to 'na' vs 'untested' for rbf sending tests when service doesn’t send via rbf

@0xB10C 0xB10C mentioned this pull request Aug 12, 2019
3 tasks
@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from 5d9d8c5 to f114c9b Compare August 13, 2019 11:33
@bitschmidty
Copy link
Contributor Author

rebased on master to get the latest compatibility styling and templates

@moneyball
Copy link
Contributor

Screen Shot 2019-08-13 at 4 15 27 PM

i noticed that whichever section was clicked through to gets this blue background. it looks a bit out of place when scrolling around the page. is it intentional?

@moneyball
Copy link
Contributor

Screen Shot 2019-08-13 at 4 16 54 PM

i'm wondering if we should have X instead of ? for wallets that don't support BIP125...the remaining portions of sending RBF are known to not work, right, so should be X not ?

@moneyball
Copy link
Contributor

Screen Shot 2019-08-13 at 4 18 42 PM

is the checkmark the same size as the X? my eyes tell me the X is bigger, which makes it more prominent, and almost fooled me into thinking that it was affirmative that the feature was supported.

@moneyball
Copy link
Contributor

Should we put Segwit addresses section above RBF? I realize that isn't the order the research was conducted, but I would think we should order it based on what we believe will be of interest to our audience. I suspect there is more interest in Segwit support than RBF.

@bitschmidty
Copy link
Contributor Author

i noticed that whichever section was clicked through to gets this blue background. it looks a bit out of place when scrolling around the page. is it intentional?

Yep. We wanted to anchor link the user to the applicable section (based on the link they clicked on) and also visually indicate the section of the page that was referenced from the preceding page. Do you think there is something more we can do to clarify?

i'm wondering if we should have X instead of ? for wallets that don't support BIP125...the remaining portions of sending RBF are known to not work, right, so should be X not ?

I agree the ? might be confusing for the status of "untested" which is what those tests are. I think it is best to have a dash '-'. Which is actually the character that we use for "N/A" status in the table as well. The dash icon is still clickable through to the details of the test. I dont like the X because we really were not able to test it, so "untested" is correct, but I agree ? might not be best.

Should we put Segwit addresses section above RBF? I realize that isn't the order the research was conducted, but I would think we should order it based on what we believe will be of interest to our audience. I suspect there is more interest in Segwit support than RBF.

I dont have a strong preference on this. @jnewbery ?

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch 4 times, most recently from 4bce232 to f114c9b Compare August 14, 2019 00:36
@harding
Copy link
Collaborator

harding commented Aug 14, 2019

I'd also slightly prefer Segwit before RBF. Changing that only requires moving stuff around in one file, so it shouldn't be much work (I'm happy to do it).

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from f114c9b to 493f4e8 Compare August 14, 2019 00:47
@bitschmidty bitschmidty reopened this Aug 14, 2019
@jnewbery
Copy link
Contributor

Should we put Segwit addresses section above RBF?

I'd also slightly prefer Segwit before RBF. Changing that only requires moving stuff around in one file, so it shouldn't be much work (I'm happy to do it).

ACK. Let's do that.

I also find it slightly odd that now that the RBF and segwit tables link to #rbf and #segwit, there isn't a direct link to the top of the details page. One thing we could potentially do is change rbf and segwit to be tabs or collapsible sections.

@harding
Copy link
Collaborator

harding commented Aug 14, 2019

@jnewbery

One thing we could potentially do is change rbf and segwit to be tabs or collapsible sections.

Putting the sections inside <details> tags would be easy for making them collapsible, but if they're collapsed by default then the links to the anchor targets couldn't automatically expand them without JS. So far we've avoided any JS dependencies on the site except for special features like particular bech32 sending support sections. (I don't know how to do tabs at all without JS, but even if there's a pure-CSS way, I suspect it would have the same problem.)

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from d97797e to 841cce9 Compare August 14, 2019 14:30
@bitschmidty
Copy link
Contributor Author

squashed commits to one per evaluated service

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from 841cce9 to 42a63c1 Compare August 14, 2019 15:36
@bitschmidty
Copy link
Contributor Author

pushed a commit for the updated Blockstream Green logo vs older GreenAddress logo

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch 2 times, most recently from b4a1eb0 to b3d3238 Compare August 14, 2019 22:15
@moneyball
Copy link
Contributor

I still see ? instead of dash.

My understanding is that the checkmark size will not be changed.

@bitschmidty
Copy link
Contributor Author

I still see ? instead of dash.

I think we can leave this as untested. If the icons become confusing for users (for this reason or others we have not thought of) we can revisit.

My understanding is that the checkmark size will not be changed.

Yep!

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-electrum-greenaddress-jaxx-ledger-live branch from b3d3238 to bf5b4d9 Compare August 19, 2019 15:26
@bitschmidty
Copy link
Contributor Author

pushed a commit which removed segwitv1 usability examples, since we are not including segwitv1 data for now

@bitschmidty bitschmidty merged commit 3f6d701 into bitcoinops:master Aug 20, 2019
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Jan 3, 2022
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Jan 3, 2022
bitschmidty pushed a commit to harding/bitcoinops.github.io that referenced this pull request Jan 5, 2022
bitschmidty pushed a commit that referenced this pull request Jan 5, 2022
harding added a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants