-
Notifications
You must be signed in to change notification settings - Fork 137
Compatibility data: electrum greenaddress jaxx ledger-live mycelium #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility data: electrum greenaddress jaxx ledger-live mycelium #181
Conversation
7907baf
to
6c1ba16
Compare
6c1ba16
to
0764f75
Compare
rebased |
Added mycelium |
@moneyball - please review for typos/formatting/etc. Let me know if you can't review this week. Thanks! |
pushed commits with:
|
5d9d8c5
to
f114c9b
Compare
rebased on master to get the latest compatibility styling and templates |
Should we put Segwit addresses section above RBF? I realize that isn't the order the research was conducted, but I would think we should order it based on what we believe will be of interest to our audience. I suspect there is more interest in Segwit support than RBF. |
Yep. We wanted to anchor link the user to the applicable section (based on the link they clicked on) and also visually indicate the section of the page that was referenced from the preceding page. Do you think there is something more we can do to clarify?
I agree the ? might be confusing for the status of "untested" which is what those tests are. I think it is best to have a dash '-'. Which is actually the character that we use for "N/A" status in the table as well. The dash icon is still clickable through to the details of the test. I dont like the X because we really were not able to test it, so "untested" is correct, but I agree ? might not be best.
I dont have a strong preference on this. @jnewbery ? |
4bce232
to
f114c9b
Compare
I'd also slightly prefer Segwit before RBF. Changing that only requires moving stuff around in one file, so it shouldn't be much work (I'm happy to do it). |
f114c9b
to
493f4e8
Compare
ACK. Let's do that. I also find it slightly odd that now that the RBF and segwit tables link to |
Putting the sections inside |
d97797e
to
841cce9
Compare
squashed commits to one per evaluated service |
841cce9
to
42a63c1
Compare
pushed a commit for the updated Blockstream Green logo vs older GreenAddress logo |
b4a1eb0
to
b3d3238
Compare
I still see ? instead of dash. My understanding is that the checkmark size will not be changed. |
I think we can leave this as untested. If the icons become confusing for users (for this reason or others we have not thought of) we can revisit.
Yep! |
b3d3238
to
bf5b4d9
Compare
pushed a commit which removed segwitv1 usability examples, since we are not including segwitv1 data for now |
No description provided.