Skip to content

Compatibility data: coinbase conio copay edge #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2019
Merged

Compatibility data: coinbase conio copay edge #180

merged 4 commits into from
Aug 20, 2019

Conversation

bitschmidty
Copy link
Contributor

No description provided.

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 2985eef to b170ddb Compare August 6, 2019 16:01
@jnewbery jnewbery force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from b170ddb to 0bb3566 Compare August 7, 2019 01:37
@jnewbery
Copy link
Contributor

jnewbery commented Aug 7, 2019

rebased

@jnewbery
Copy link
Contributor

jnewbery commented Aug 7, 2019

@adamjonas - please review for typos/formatting/etc. Let me know if you can't review this week. Thanks!

adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
adamjonas
adamjonas reviewed Aug 7, 2019
View reviewed changes
@adamjonas
Copy link
Member

Minor stuff.

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 0bb3566 to 33e0c10 Compare August 8, 2019 16:57
@bitschmidty
Copy link
Contributor Author

Pushed a commit to address @adamjonas' (thank you sir!) feedback

@bitschmidty
Copy link
Contributor Author

pushed commits with:

  • changes to the captions prefixes made per Launch compatibility matrix #183 (comment)
  • changes to caption wording based on Bitcoin Core wallet example
  • moved images into /rbf/ sub folder to be consistent with /segwit/ usability images (and more clear)
  • changes to 'na' vs 'untested' for rbf sending tests when service doesn’t send via rbf

@0xB10C 0xB10C mentioned this pull request Aug 12, 2019
Merged
3 tasks
@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 3ef7979 to 0d348ad Compare August 13, 2019 11:28
@bitschmidty
Copy link
Contributor Author

rebased on master to get the latest compatibility styling and templates

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 0d348ad to 2d8ec52 Compare August 14, 2019 02:12
@bitschmidty
Copy link
Contributor Author

rebased and pushed commits for image optimizations

@0xB10C 0xB10C mentioned this pull request Aug 14, 2019
Merged
@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 2d8ec52 to 00babc9 Compare August 14, 2019 14:24
@bitschmidty
Copy link
Contributor Author

squashed commits to one per evaluated service

@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 00babc9 to 8d328f8 Compare August 19, 2019 15:20
@bitschmidty
Copy link
Contributor Author

pushed a commit with changes that removed segwitv1 usability examples, since we are not including the data for now

@bitschmidty
Copy link
Contributor Author

@adamjonas looking to merge this one today. If you have a second for final review

https://deploy-preview-180--bitcoinops.netlify.com/en/compatibility/

adamjonas
adamjonas reviewed Aug 19, 2019
View reviewed changes
@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from 8d328f8 to e89a5e7 Compare August 19, 2019 19:40
adamjonas
adamjonas requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@adamjonas adamjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major thing I saw was the blank line on the index page. The rest looks good.

@bitschmidty bitschmidty mentioned this pull request Aug 20, 2019
Merged
@bitschmidty bitschmidty force-pushed the 2019-08-compatibility-data-coinbase-conio-copay-edge branch from e89a5e7 to aa07441 Compare August 20, 2019 01:54
@jnewbery
Copy link
Contributor

I've reviewed the Conio bech32 support. Looks good!

ACK aa07441

@bitschmidty bitschmidty merged commit e6fb89f into bitcoinops:master Aug 20, 2019
@murchandamus murchandamus mentioned this pull request Jul 17, 2023
Merged
@murchandamus murchandamus mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harding harding harding left review comments

@adamjonas adamjonas adamjonas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitschmidty @jnewbery @adamjonas @harding