Skip to content

Compatibility template: remove empty row condition #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bitschmidty
Copy link
Contributor

Per @harding 's suggestion, this PR removes the conditional for the empty row if a wallet/service did not have a particular test.

@harding
Copy link
Collaborator

harding commented Aug 20, 2019

Sorry, I should've tested my previous diff before sending it to you, this also needs to move the <tr> inside the if statement:

--- a/en/compatibility.md
+++ b/en/compatibility.md
@@ -35,9 +35,9 @@ h1, h2, h3, h4, h5, h6 { text-align: center; }
 {% assign tools = site.data.compatibility | sort %}
 {% for wrapped_tool in tools %}
   {% assign tool = wrapped_tool[1] %}
-  <tr>
-    <td><a href="{{tool.internal_url}}#segwit">{{tool.name}}</a></td>
     {% if tool.segwit %}
+      <tr>
+        <td><a href="{{tool.internal_url}}#segwit">{{tool.name}}</a></td>
 
       {% assign segwit_receive_default = "" %}
       {% assign segwit_receive_default_class = "default" %}
@@ -72,8 +72,8 @@ h1, h2, h3, h4, h5, h6 { text-align: center; }
       {% include functions/compat-cell.md state=tool.segwit.features.send.bech32 anchor="#segwit-send-bech32" %}
       {% include functions/compat-cell.md state=tool.segwit.features.send.bech32_p2wsh anchor="#segwit-send-bech32_p2wsh" %}
       {% include functions/compat-cell.md state=tool.segwit.features.send.change_bech32 anchor="#segwit-send-change_bech32" %}
+      </tr>
     {% endif %}
-  </tr>
 {% endfor %}
 
 </table>

I did very quickly test that by deleting the bitcoin core segwit data and previewing.

@bitschmidty bitschmidty force-pushed the compatibility-template-remove-empty-row-conditional branch from f4c5c87 to 24b5b86 Compare August 20, 2019 01:38
@bitschmidty
Copy link
Contributor Author

@harding poor testing on my side. moved the row element inside the conditional now.

@harding
Copy link
Collaborator

harding commented Aug 20, 2019

Tested ACK 24b5b86 Thanks!

@bitschmidty bitschmidty merged commit 8ee8818 into bitcoinops:master Aug 20, 2019
@jnewbery jnewbery added the compatibility Enhancements or bugs for the compatibility matrix label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Enhancements or bugs for the compatibility matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants