Skip to content

add ConnectEmbed + Fix double connection issue with Safe/Smart in ConnectWallet #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 20, 2023
Merged

add ConnectEmbed + Fix double connection issue with Safe/Smart in ConnectWallet #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
32c52e2
Connect Embed + allow hiding the connection
MananTank Nov 10, 2023
9d6dfc2
Merge branch 'main' into mnn/connect-embed
MananTank Nov 15, 2023
e1ef9b4
fixes
MananTank Nov 15, 2023
e45e929
add changeset
MananTank Nov 15, 2023
a70b4d9
make embed a valid component
MananTank Nov 15, 2023
e4a4e30
add API to disconnect hidden connection
MananTank Nov 15, 2023
2938ad0
Merge branch 'main' into mnn/connect-embed
MananTank Nov 16, 2023
e31b4e1
update
MananTank Nov 16, 2023
ea58312
Merge branch 'main' into mnn/connect-embed
MananTank Nov 16, 2023
4fda0f3
update
MananTank Nov 17, 2023
9bf642a
Merge branch 'main' into mnn/connect-embed
MananTank Nov 17, 2023
4a24f6e
update
MananTank Nov 17, 2023
5f090fc
update
MananTank Nov 17, 2023
9f5cd62
update
MananTank Nov 17, 2023
53ca0c9
cleanup
MananTank Nov 17, 2023
aeba183
update
MananTank Nov 17, 2023
1ccf922
update changeset
MananTank Nov 17, 2023
6bed01c
update
MananTank Nov 17, 2023
70c1ddb
update
MananTank Nov 17, 2023
138ba73
update
MananTank Nov 17, 2023
27f2206
fix connection status
MananTank Nov 17, 2023
2380748
Merge branch 'main' into mnn/connect-embed
MananTank Nov 20, 2023
83dd80e
update translations
MananTank Nov 20, 2023
ec68a56
mark ConnectModalInline as internal
MananTank Nov 20, 2023
8b9ca27
reset states on connect in connect embed
MananTank Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/khaki-queens-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@thirdweb-dev/react-core": patch
"@thirdweb-dev/react": patch
---

- Add `ConnectEmbed`` component to embed the ConnectWallet's Modal UI directly in page

- Fix `ConnectWallet` component setting personal wallet as "connected" wallet when connecting a Safe / Smart Wallet
Loading