Skip to content

add ConnectEmbed + Fix double connection issue with Safe/Smart in ConnectWallet #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 20, 2023
Merged

add ConnectEmbed + Fix double connection issue with Safe/Smart in ConnectWallet #1952

merged 25 commits into from
Nov 20, 2023

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Nov 15, 2023 •
edited
Loading

  • Add ConnectEmbed component to embed the ConnectWallet Modal's content in the page
  • Fix the double connection issue when connecting Safe or Smart wallet when using the ConnectWallet / ConnectEmbed component by not setting the personal wallet as the connected wallet and saving the connection information of the personal wallet in a separate state

@MananTank MananTank requested a review from a team as a code owner November 15, 2023 12:42
@MananTank MananTank requested a review from a team November 15, 2023 12:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8b9ca27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MananTank MananTank marked this pull request as draft November 15, 2023 12:42
@MananTank MananTank added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 15, 2023
@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

iketw
iketw reviewed Nov 15, 2023
View reviewed changes
@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

@MananTank MananTank removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 17, 2023
@MananTank MananTank marked this pull request as ready for review November 17, 2023 13:37
@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

joaquim-verges
joaquim-verges reviewed Nov 17, 2023
View reviewed changes
@MananTank MananTank added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit fb0cb67 Nov 20, 2023
@MananTank MananTank deleted the mnn/connect-embed branch November 20, 2023 18:00
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
Merged
MananTank added a commit that referenced this pull request Nov 22, 2023
@MananTank
Revert "add ConnectEmbed + Fix double connection issue with Safe/Smar…
8d9431d 
…t in ConnectWallet (#1952)"

This reverts commit fb0cb67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquim-verges joaquim-verges joaquim-verges left review comments

@iketw iketw iketw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MananTank @joaquim-verges @iketw