Skip to content

Minor docs bug-fixes #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Minor docs bug-fixes #938

wants to merge 11 commits into from

Conversation

v-izmalkov
Copy link
Contributor

Fix gh-893 feedback: Submodule box.info
Fix gh-869 Сonfusing wording in box.backup page
Fix gh-876 document reaction on error in replication configuration change
Update gh-868 Tarantool dependency list was changed
Fix gh-915 feedback: Building from source
Fix gh-902 feedback: Сборка из исходных файлов
Fix gh-920 feedback: Module vshard
Fix gh-922 feedback: Module vshard

Vladimir I added 10 commits September 13, 2019 16:48
Added follow status.
Will need a translation.
Fixed status name and some wording in description.
Fixed description regarding garbage collection in backup.start()
Fixed backup.start() use description in disaster recovery.
Note the ref-link to box.backup.stop() is the same as the start().
…ange.

Clarified description of situation 2 (local recovery) and added proposed variants to leave orphan status.
Fixed py27-msgpack package name and added a temporary warning about current possible problem with openssl111 depemdency. This warning to be considered for deletion after fixing dependencies.
Fixed by adding one command. Translation not needed.
Added double ` for make command. Both Eng and Rus versions.
Corrected with the git-repository ref. Need translation fix (pot file generation and review).
@v-izmalkov v-izmalkov requested a review from lenkis October 3, 2019 12:25
garbage collection till the next ``box.backup.stop()`` and
will return a list of files to back up.
:ref:`administrative console <admin-security>`. This will return a list of
files to back up and suspend garbage collection of them till the next ``box.backup.stop()``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...suspend garbage collection FOR them...

made with older checkpoints.
deletion of expired checkpoints with :ref:`box.backup.start() <admin-backups-backup_start>`.
This will prevent the Tarantool garbage collector from removing files
made with older checkpoints until :ref:`box.backup.stop() <admin-backups-backup_start>` called.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... IS called.

@@ -198,6 +198,16 @@ is less than or equal to the number of seconds specified in
If ``replication_sync_lag`` is unset (nil) or set to TIMEOUT_INFINITY, then
the replica skips the "sync" state and switches to "follow" immediately.

In order to leave orphan mode you need to sync with enough
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... with A SUFFICIENT NUMBER (replication_connect_quorum) OF instances.

nodes.
nodes. If failed - set status to 'orphan'.
(Attempts to sync will continue in the background and when/if they succeed
then 'orphan' status will end.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... 'orphan' status will be changed to 'connected'.)

@@ -186,6 +190,11 @@ the preferences can differ. But strategically the steps are always the same.

This creates the 'tarantool' executable in the ``src/`` directory.

.. NOTE::

If you encounter a ``curl`` or ``OpenSSL`` errors on this step try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you encounter curl or OpenSSL errors on this step, try
installing an openssl111 package of the specific 1.1.1d version.

" files to back up."
":ref:`administrative console <admin-security>`. This will
" return a list of files to back up and suspend garbage"
" collection of them till the next ``box.backup.stop()``."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... collection FOR them...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it matter for translation whether i change msgid in po files if they are generated as we discussed?

Adressed minor issues after review.
@lenkis lenkis closed this Oct 28, 2019
@lenkis
Copy link
Contributor

lenkis commented Oct 28, 2019

To be rebased and re-submitted later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants