Skip to content

Delete description support #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Delete description support #50

merged 1 commit into from
Jan 2, 2020

Conversation

kornelski
Copy link
Contributor

Rust has deprecated Error::description and started warning against using it.

This PR removes support for description() in a backwards-compatible way. Descriptions won't be generated, and existing description definitions are no-ops.

@tailhook
Copy link
Owner

tailhook commented Jan 2, 2020

As we also need #44 and most projects think of bumping minimum rust version as a breaking change. Should we just delete description altogether and make a breaking release?

@kornelski
Copy link
Contributor Author

Why not both?

This change is backwards-compatible, so it could be released straight away. And then the remaining code can be cleaned up for the next release.

@tailhook tailhook merged commit 2a9d649 into tailhook:master Jan 2, 2020
@tailhook
Copy link
Owner

tailhook commented Jan 2, 2020

Hm. Yes that makes sense.

@tailhook
Copy link
Owner

tailhook commented Jan 2, 2020

Released as v1.2.3

@tailhook
Copy link
Owner

tailhook commented Jan 2, 2020

Is the fact that it changes default Display implementation should be considered as a breaking change?

@tailhook
Copy link
Owner

tailhook commented Jan 3, 2020

Also, this breaks any rust that has no default implementation for description() method. Which is somewhere between 1.24 an 1.31. Not sure if I should yank v1.2.3 now...

@kornelski
Copy link
Contributor Author

kornelski commented Jan 4, 2020

It is more problematic than I assumed. I didn't consider old Rust versions, since I don't support them in any of my crates.

Maybe these changes aren't breaking in practice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants