Skip to content

Use edition = "2018" #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2020
Merged

Use edition = "2018" #44

merged 4 commits into from
Jan 2, 2020

Conversation

TimDiekmann
Copy link

@TimDiekmann TimDiekmann commented Mar 13, 2019

Uses edition 2018 and removes try!, as it's not available anymore in 2018.

With those changes it should be trivial to add no_std support as core can be used everywhere except in std::error.

cc #33

@tailhook
Copy link
Owner

Hi! Thank you for your work.

Do you mean this macro can't be used as is in 2018? Can we just remove try macro but don't bump edition? (I'm still not sure whether it's already the time and if bumping a minimum rust version is a non-breaking change).

@TimDiekmann
Copy link
Author

No it's working with 2018. I just wanted to work a bit towards no_std support, and for testing this, it's easier with "edition = 2018" as no extern crate core is needed. But you are right that bumping a minimum version of rust is maybe a little bit too early, however, in CI you don't have tests for older versions, you only test the current stable.

The change to edition 2018 shouldn't be a breaking change anyway, as try! is only used in tests.

@TimDiekmann
Copy link
Author

Feel free to just close this, it wasn't a that big effort 🙂

@kornelski
Copy link
Contributor

It would be good to merge this. try! generates deprecation warnings now.

@tailhook tailhook merged commit 944cf10 into tailhook:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants