[clang] Only use warn_nserrordomain_invalid_decl for APINotes #2373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only warn on an invalid error domain set via APINotes as a temporary workaround until clients are updated.
|
@swift-ci Please test |
|
@DougGregor FYI, the enum causing the issue here was associated to the error domain by an APINote only. Which explains why it was just a |
|
These are the same failing tests as before. There's no test for the APINotes use of ns_error_domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only warn on an invalid error domain set via APINotes as a temporary workaround until clients are updated.
This is fix for the workaround in #2368.