[clang] Downgrade err_nserrordomain_invalid_decl to a warning #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to the ns_error_domain logic requires the error domain symbol to be defined before enums referring to it. Temporarily downgrade the err_nserrordomain_invalid_decl error to a warning when the decl is not found until the code affected by this is updated.
|
@swift-ci Please test |
|
This is a temporary solution for the failure at https://ci.swift.org/view/Swift%20rebranch/job/oss-swift-rebranch-incremental-RA-macos/29/consoleFull#-11554351773122a513-f36a-4c87-8ed7-cbc36a1ec144 tracked by rdar://73371596. |
DougGregor
approved these changes
Jan 22, 2021
|
The failing tests appear to be unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the
ns_error_domainlogic requires the error domainsymbol to be defined before enums referring to it. Temporarily downgrade
the
err_nserrordomain_invalid_declerror to a warning when the decl isnot found until the code affected by this is updated.