Skip to content

chore: [STMS-4062] Migrate js-tools to pnpm #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b57e7ed
chore: [STMS-4062] Migrate js-tools to pnpm
SiriusCrain Mar 27, 2025
3a42bd6
Fixed js-tools packages
SiriusCrain Mar 27, 2025
6018b65
Upgraded node version
SiriusCrain Mar 27, 2025
d89925f
Fixed js-tools build
SiriusCrain Mar 27, 2025
8d25e04
Changed rimraf version
SiriusCrain Mar 27, 2025
6314a6b
Added rimraft to main package
SiriusCrain Mar 27, 2025
510e159
Added @types/babel__core to main package
SiriusCrain Mar 27, 2025
d9dda38
Fixed deps
SiriusCrain Mar 27, 2025
d280f5d
Fixed deps
SiriusCrain Mar 27, 2025
aa2c69d
Fixed deps
SiriusCrain Mar 27, 2025
c4a8a29
Changed oclif
SiriusCrain Mar 27, 2025
cb6af22
Changed oclif
SiriusCrain Mar 27, 2025
c96d531
Changed oclif
SiriusCrain Mar 27, 2025
df038c7
Changed oclif
SiriusCrain Mar 27, 2025
e1972db
Changed oclif
SiriusCrain Mar 27, 2025
97604cc
Changed oclif
SiriusCrain Mar 27, 2025
e777d61
Changed oclif
SiriusCrain Mar 27, 2025
898e5b4
Changed oclif
SiriusCrain Mar 27, 2025
26931aa
Changed oclif
SiriusCrain Mar 27, 2025
a2c7cd7
Changed oclif
SiriusCrain Mar 27, 2025
5e4fda6
Changed oclif
SiriusCrain Mar 27, 2025
9cd3daf
Changed oclif
SiriusCrain Mar 27, 2025
7a0fca0
Changed oclif
SiriusCrain Mar 27, 2025
18395b3
Changed oclif
SiriusCrain Mar 27, 2025
6b3b92a
Changed oclif
SiriusCrain Mar 27, 2025
7f9d733
Changed oclif
SiriusCrain Mar 27, 2025
5a93f24
Changed oclif
SiriusCrain Mar 27, 2025
885cd2a
Changed oclif
SiriusCrain Mar 27, 2025
b23b504
Changed oclif
SiriusCrain Mar 27, 2025
814915e
Changed oclif
SiriusCrain Mar 27, 2025
497a159
Changed oclif
SiriusCrain Mar 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"node": "16",
"node": "20",
"buildCommand": "build",
"packages": [
"packages/babel-preset",
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,18 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: pnpm/action-setup@v4
with:
version: 10
- uses: umidbekk/actions/prepare-node-repo@v2
Comment on lines +16 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiriusCrain Did you have time to check if we can use prepare-node-repo@ without pnpm/action-setup? And can you replace umidbekk/actions/prepare-node-repo@v2 with superdispatch one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can replace umidbek's package, but since other workflows were requiring addin pnpm-action...

with:
cache-key: npm-v2-

- run: yarn tsc
- run: yarn lint
- run: pnpm tsc
- run: pnpm lint
- uses: superdispatch/actions/[email protected]
with:
command: yarn test
update-command: yarn test -u
command: pnpm test
update-command: pnpm test -u
- uses: codecov/codecov-action@v2
- run: yarn build
- run: pnpm build
5 changes: 2 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,11 @@ node_modules/


# Logs
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
pnpm-error.log*

# Coverage directory used by tools like istanbul
coverage

# Builds
dist/

2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn lint-staged
pnpm lint-staged
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "0.8.0",
"npmClient": "yarn",
"npmClient": "pnpm",
"useWorkspaces": true,
"packages": [
"packages/*"
Expand Down
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
},
"scripts": {
"build": "lerna run build --parallel",
"prelint": "yarn build",
"prelint": "pnpm build",
"lint": "js-tools lint",
"prepare": "husky install",
"prerelease": "yarn --force && yarn tsc && yarn lint && yarn test",
"prerelease": "pnpm --force && pnpm tsc && pnpm lint && pnpm test",
"release": "lerna publish",
"tdd": "jest --watch",
"test": "jest --coverage"
Expand Down Expand Up @@ -49,6 +49,8 @@
"@babel/cli": "7.18.10",
"@babel/core": "7.26.9",
"@babel/runtime": "7.26.9",
"@oclif/core": "^2.6.3",
"@types/babel__core": "^7.20.5",
"@types/eslint": "8.4.6",
"@types/find-cache-dir": "3.2.1",
"@types/jest": "27.5.2",
Expand All @@ -65,11 +67,12 @@
"lerna": "4.0.0",
"lint-staged": "12.5.0",
"prettier": "2.7.1",
"rimraf": "3.0.2",
"snapshot-diff": "0.9.0",
"ts-jest": "29.0.5",
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
"node": ">=20"
}
}
2 changes: 1 addition & 1 deletion packages/babel-preset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
#### Installation

```bash
yarn add @superdispatch/babel-preset -D
pnpm add @superdispatch/babel-preset -D
```
5 changes: 3 additions & 2 deletions packages/babel-preset/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@
"@babel/preset-typescript": "^7.26.0",
"babel-plugin-annotate-pure-calls": "^0.4.0",
"babel-plugin-dev-expression": "^0.2.2",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24"
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"rimraf": "3.0.2"
},
"peerDependencies": {
"@babel/runtime": "^7.0.0"
},
"engines": {
"node": ">=12"
"node": ">=20"
},
"publishConfig": {
"access": "public"
Expand Down
Loading
Loading