chore: [STMS-4062] Migrate js-tools to pnpm #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiriusCrain
requested review from
timurhamitov,
normurod72,
lapapooh,
umrzoq-toshkentov and
sanjar-sd
sanjar-sd
approved these changes
Mar 27, 2025
Comment on lines
+16
to
19
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10 | ||
| - uses: umidbekk/actions/prepare-node-repo@v2 |
There was a problem hiding this comment.
@SiriusCrain Did you have time to check if we can use prepare-node-repo@ without pnpm/action-setup? And can you replace umidbekk/actions/prepare-node-repo@v2 with superdispatch one?
There was a problem hiding this comment.
I think I can replace umidbek's package, but since other workflows were requiring addin pnpm-action...
Comment on lines
-46
to
+44
| "node": ">=12" | ||
| "node": ">=20" |
There was a problem hiding this comment.
@SiriusCrain IIIRC, not all our repo require node>=20, and it could become a problem during migrations.
There was a problem hiding this comment.
We can update node version in our other repos, and then use upgraded js-tools build, for now we can use current (0.8.0)
timurhamitov
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.