Skip to content

Add nowasm tag, fix nowasm inconsistency #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

angaz
Copy link
Contributor

@angaz angaz commented Aug 3, 2022

I found an inconsistency between the implementation of the wasm and nowasm files.

I thought that since it seems that this feature can be disabled, it would be nice to be able to control it from a tag. So I added that too.

The reason I came about this in the first place was that it seems that there is a Rust dependency in the wasm implementation, and that conflicts with my build system. I'm sure I could figure it out if this will not be possible in the future.

@kyleconroy
Copy link
Collaborator

that it seems that there is a Rust dependency in the wasm implementation

I'm using wasmtime which is written in Rust. It comes with pre-built libraries though, so you shouldn't need a Rust toolchain to install sqlc. Can you give me a bit more information about your setup?

@kyleconroy kyleconroy merged commit 6dd9b0e into sqlc-dev:main Aug 7, 2022
@angaz
Copy link
Contributor Author

angaz commented Aug 7, 2022

Thanks for merging my PR.

My setup involves some restricted environments where glibc is not available, as well as developers machines running various distributions of Linux, Mac, ... so we decided to have a toolbox of our internally used tools, which is statically compiled where possible. For sqlc, we are using Zig as a C compiler, and it seems to be working for us.

Please don't feel too pressured to support such a specific use-case. We are used to putting in a little effort maintaining a fork or patch set where necessary to keep this system going.

@angaz angaz deleted the nowasm branch August 7, 2022 17:32
@angaz angaz mentioned this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants