Add nowasm tag, fix nowasm inconsistency #1772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an inconsistency between the implementation of the wasm and nowasm files.
I thought that since it seems that this feature can be disabled, it would be nice to be able to control it from a tag. So I added that too.
The reason I came about this in the first place was that it seems that there is a Rust dependency in the wasm implementation, and that conflicts with my build system. I'm sure I could figure it out if this will not be possible in the future.